Addressed PR comments

Author: ebkr

.github/workflows/test.yml

@@ -39,4 +39,4 @@ jobs:
             - name: Run tests
               run: >
                   node test/folder-structure-testing/populator.mjs &&
-                  yarn run test:unit:ci
+                  yarn run test

package.json

@@ -8,7 +8,6 @@
   "license": "MIT",
   "type": "module",
   "scripts": {
-    "test": "echo \"See package.json => scripts for available tests.\" && exit 0",
     "run": "quasar dev -m electron --modern",
     "dev": "quasar dev -m electron --modern --devtools",
     "sync": "ts-node ./scripts/sync.ts",
@@ -18,7 +17,7 @@
     "publish": "quasar build --mode electron --publish always",
     "publish-win": "quasar build --mode electron -T win32 --publish always",
     "publish-linux": "quasar build --mode electron -T linux --publish always",
-    "test:unit:ci": "vitest run ./test/vitest"
+    "test": "vitest run ./test/vitest"
   },
   "dependencies": {
     "@node-steam/vdf": "^2.1.0",
@@ -102,7 +101,7 @@
     "wallaby-vue-compiler": "^1.0.3"
   },
   "engines": {
-    "node": ">= 18.0.0",
+    "node": "^20.19.0 || >=22.12.0",
     "npm": ">= 10.0.0",
     "yarn": ">= 1.21.1"
   }

src/providers/node/app/AppWindowImplementation.ts

@@ -1,7 +1,5 @@
 import { AppWindowProvider } from './app_window';
 
-let execIdentifier = 0;
-
 export const AppWindowImplementation: AppWindowProvider = {
     getPlatform: () => window.app.getPlatform(),
 }

test/vitest/tests/unit/ModLinker/ModLinker.spec.ts

@@ -9,14 +9,14 @@ import ManagerSettings from '../../../../../src/r2mm/manager/ManagerSettings';
 import FileUtils from '../../../../../src/utils/FileUtils';
 import GameDirectoryResolverProvider from '../../../../../src/providers/ror2/game/GameDirectoryResolverProvider';
 import { ManagerSettingsInterfaceHolder } from '../../../../../src/r2mm/manager/SettingsDexieStore';
-import InMemoryFsProvider from "../../../stubs/providers/InMemory.FsProvider";
-import SettingsRedirectGameDirectoryResolver from "../../../stubs/providers/SettingsRedirectGameDirectoryResolver";
+import InMemoryFsProvider from '../../../stubs/providers/InMemory.FsProvider';
+import SettingsRedirectGameDirectoryResolver from '../../../stubs/providers/SettingsRedirectGameDirectoryResolver';
 import { describe, beforeAll, test, expect } from 'vitest';
 import { providePathImplementation } from '../../../../../src/providers/node/path/path';
 import { TestPathProvider } from '../../../stubs/providers/node/Node.Path.Provider';
 import { provideAppWindowImplementation } from '../../../../../src/providers/node/app/app_window';
 import { TestAppWindowProvider } from '../../../stubs/providers/node/AppWindow.Provider';
-2
+
 class ProfileProviderImpl extends ProfileProvider {
     ensureProfileDirectory(directory: string, profile: string): void {
         FsProvider.instance.mkdirs(path.join(directory, profile));
@@ -28,7 +28,7 @@ describe.skipIf(process.platform !== 'win32')('ModLinker', async () => {
     let settings!: ManagerSettings;
 
     beforeAll(async () => {
-            providePathImplementation(() => TestPathProvider);
+        providePathImplementation(() => TestPathProvider);
         provideAppWindowImplementation(() => TestAppWindowProvider);
 
         new Profile('TestProfile');
@@ -46,32 +46,32 @@ describe.skipIf(process.platform !== 'win32')('ModLinker', async () => {
         // Hack to work around Dexie loading issue during test
         (ManagerSettings['CONTEXT'] as any) = ({
             global: {
-                steamDirectory: "TEST_STEAM_PATH"
+                steamDirectory: 'TEST_STEAM_PATH'
             },
             gameSpecific: {
-                gameDirectory: "TEST_GAME_DIRECTORY"
+                gameDirectory: 'TEST_GAME_DIRECTORY'
             }
-        } as ManagerSettingsInterfaceHolder)
+        } as ManagerSettingsInterfaceHolder);
         // await settings.setGameDirectory("GAME_DIR");
         await FileUtils.ensureDirectory(settings.getContext().gameSpecific.gameDirectory!);
     });
 
     test('Install, no existing files', async () => {
-        const testFile = Profile.getActiveProfile().joinToProfilePath("test_file");
-        await FsProvider.instance.writeFile(testFile, "content");
-        expect(await FsProvider.instance.exists(path.join(settings.getContext().gameSpecific.gameDirectory!, "test_file"))).toBeFalsy();
+        const testFile = Profile.getActiveProfile().joinToProfilePath('test_file');
+        await FsProvider.instance.writeFile(testFile, 'content');
+        expect(await FsProvider.instance.exists(path.join(settings.getContext().gameSpecific.gameDirectory!, 'test_file'))).toBeFalsy();
         await ModLinker.link(Profile.getActiveAsImmutableProfile(), GameManager.defaultGame);
-        expect(await FsProvider.instance.exists(path.join(settings.getContext().gameSpecific.gameDirectory!, "test_file"))).toBeTruthy();
+        expect(await FsProvider.instance.exists(path.join(settings.getContext().gameSpecific.gameDirectory!, 'test_file'))).toBeTruthy();
     });
 
     test('Install, file already exists, no overwrite', async () => {
-        const testFile = Profile.getActiveProfile().joinToProfilePath("test_file");
+        const testFile = Profile.getActiveProfile().joinToProfilePath('test_file');
         expect(await FsProvider.instance.exists(testFile)).toBeTruthy();
         const oldStat = await FsProvider.instance.stat(testFile);
         await new Promise(resolve => {
             setTimeout(async () => {
                 await ModLinker.link(Profile.getActiveAsImmutableProfile(), GameManager.defaultGame);
-                expect(await FsProvider.instance.exists(path.join(settings.getContext().gameSpecific.gameDirectory!, "test_file"))).toBeTruthy();
+                expect(await FsProvider.instance.exists(path.join(settings.getContext().gameSpecific.gameDirectory!, 'test_file'))).toBeTruthy();
                 const newStat = await FsProvider.instance.stat(testFile);
                 expect(newStat.mtime).toEqual(oldStat.mtime);
                 resolve(undefined);
@@ -80,14 +80,14 @@ describe.skipIf(process.platform !== 'win32')('ModLinker', async () => {
     });
 
     test('Install, file already exists, overwritten', async () => {
-        const testFile = Profile.getActiveProfile().joinToProfilePath("test_file");
+        const testFile = Profile.getActiveProfile().joinToProfilePath('test_file');
         expect(await FsProvider.instance.exists(testFile)).toBeTruthy();
         const oldStat = await FsProvider.instance.stat(testFile);
-        await FsProvider.instance.writeFile(testFile, "modified");
+        await FsProvider.instance.writeFile(testFile, 'modified');
         await new Promise(resolve => {
             setTimeout(async () => {
                 await ModLinker.link(Profile.getActiveAsImmutableProfile(), GameManager.defaultGame);
-                expect(await FsProvider.instance.exists(path.join(settings.getContext().gameSpecific.gameDirectory!, "test_file"))).toBeTruthy();
+                expect(await FsProvider.instance.exists(path.join(settings.getContext().gameSpecific.gameDirectory!, 'test_file'))).toBeTruthy();
                 const newStat = await FsProvider.instance.stat(testFile);
                 expect(newStat.mtime).not.toEqual(oldStat.mtime);
                 resolve(undefined);

test/vitest/utils/InstallLogicUtils.ts

@@ -54,7 +54,6 @@ export async function installLogicBeforeEach(internalFolderName: string) {
     InstallationRules.apply();
     ConflictManagementProvider.provide(() => new ConflictManagementProviderImpl());
     InMemoryFsProvider.setMatchMode("CASE_SENSITIVE");
-    providePathImplementation(() => TestPathProvider);
 }
 
 /**