Clean up some warnings (#1315)

This solves a few random warnings that have been floating around for a while. Not really a huge deal:
- Add `pstore` to the bundle. TBH I think this warning would otherwise just go away when pstore stops being bundled with Ruby but yaml still is, but I'm tired of seeing this warning.
- Opt-in to frozen string literals everywhere. This fixes a test that was triggering warnings about them, but is also just something that should have been done in general, since this will become the default at some point in Ruby's future. (Nothing about the specific test at issue is really changing, though. As far as I can tell, Rails test requests pass string values for POST bodies directly on to Rack's mock request, which then tries to set the string's encoding, which causes the warning. I guess it does not do so if the string is frozen.)

* Opt into frozen string literals everywhere

Should have done this long ago!

Author: Mr0grog

.rubocop.yml

@@ -152,6 +152,9 @@ Style/ExponentialNotation:
 Style/FormatStringToken:
   Enabled: false
 
+Style/FrozenStringLiteralComment:
+  EnforcedStyle: always_true
+
 Style/GuardClause:
   Enabled: false
 

.rubocop_todo.yml

@@ -49,13 +49,6 @@ Style/OptionalBooleanParameter:
     - 'app/jobs/analyze_change_job.rb'
     - 'app/models/application_record.rb'
 
-# Offense count: 67
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: when_needed, always, never
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
 # Offense count: 4
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.

Gemfile

@@ -35,6 +35,9 @@ gem 'hiredis'
 gem 'sentry-ruby', '~> 5.26.0'
 gem 'sentry-rails', '~> 5.26.0'
 
+# We don't make direct use of this; it's really here to suppress a warning about upcoming changes to bundled gems.
+gem "pstore", "~> 0.2.0"
+
 # See https://github.com/rails/execjs#readme for more supported runtimes
 # gem 'therubyracer', platforms: :ruby
 # Build JSON APIs with ease. Read more: https://github.com/rails/jbuilder

Gemfile.lock

@@ -268,6 +268,7 @@ GEM
       method_source (~> 1.0)
     pry-rails (0.3.11)
       pry (>= 0.13.0)
+    pstore (0.2.0)
     psych (5.2.6)
       date
       stringio
@@ -468,6 +469,7 @@ DEPENDENCIES
   pg (~> 1.6)
   postmark-rails
   pry-rails
+  pstore (~> 0.2.0)
   puma (~> 7.1)
   pundit (~> 2.5.2)
   rack-brotli

Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 

app/channels/application_cable/channel.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ApplicationCable
   class Channel < ActionCable::Channel::Base
   end

app/channels/application_cable/connection.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ApplicationCable
   class Connection < ActionCable::Connection::Base
   end

app/controllers/admin/users_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Admin
   class UsersController < ApplicationController
     before_action :authenticate_user!

app/controllers/admin_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AdminController < ApplicationController
   protect_from_forgery with: :exception
 

app/controllers/api/v0/annotations_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Api::V0::AnnotationsController < Api::V0::ApiController
   include SortingConcern
   include BlockedParamsConcern