[Onboarding ingest] [Fix] Prevent reinstall sample data if it already exists (#230311)

## Summary
Previously, we always reinstalled the sample data, assuming it could
help update versions if needed. However, this reinstall logic wasn’t
actually used or triggered by the frontend.

This approach led to a problem: during an incident, multiple install
requests were triggered simultaneously, which caused race conditions and
server crashes.

Now if the sample data is already installed, we simply return the
existing index without doing anything. This prevents unnecessary
reinstallation and avoids concurrent modification issues.

### Checklist
- [ ] ~~Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)~~
- [ ]
~~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials~~
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] ~~If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~
- [ ] ~~This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.~~
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

Author: yansavitski

x-pack/platform/plugins/shared/sample_data_ingest/server/services/index_manager/index_manager.test.ts

@@ -296,6 +296,20 @@ describe('IndexManager', () => {
     });
   });
 
+  describe('hasIndex', () => {
+    const indexName = 'test-index';
+
+    it('should return true when index exists', async () => {
+      esClient.indices.exists.mockResolvedValue(true);
+
+      const result = await indexManager.hasIndex({ indexName, esClient });
+
+      expect(result).toBe(true);
+      expect(esClient.indices.exists).toHaveBeenCalledWith({ index: indexName });
+      expect(logger.warn).not.toHaveBeenCalled();
+    });
+  });
+
   it('should initialize with correct properties', () => {
     const customLogger = loggerMock.create();
     const customInferenceId = 'custom-inference';

x-pack/platform/plugins/shared/sample_data_ingest/server/services/index_manager/index_manager.ts

@@ -93,4 +93,19 @@ export class IndexManager {
       this.log.warn(`Failed to delete index [${indexName}]: ${error.message}`);
     }
   }
+
+  async hasIndex({
+    indexName,
+    esClient,
+  }: {
+    indexName: string;
+    esClient: ElasticsearchClient;
+  }): Promise<boolean> {
+    try {
+      return await esClient.indices.exists({ index: indexName });
+    } catch (error) {
+      this.log.warn(`Failed to check if index exists [${indexName}]: ${error.message}`);
+      return false;
+    }
+  }
 }

x-pack/platform/plugins/shared/sample_data_ingest/server/services/sample_data_manager/sample_data_manager.test.ts

@@ -73,6 +73,7 @@ describe('SampleDataManager', () => {
     mockIndexManager = {
       createAndPopulateIndex: jest.fn(),
       deleteIndex: jest.fn(),
+      hasIndex: jest.fn(),
       setESClient: jest.fn(),
     } as any;
 
@@ -94,6 +95,7 @@ describe('SampleDataManager', () => {
 
     mockIndexManager.createAndPopulateIndex.mockResolvedValue(undefined);
     mockIndexManager.deleteIndex.mockResolvedValue(undefined);
+    mockIndexManager.hasIndex.mockResolvedValue(false);
   });
 
   afterEach(() => {
@@ -141,7 +143,7 @@ describe('SampleDataManager', () => {
     it('should install sample data successfully', async () => {
       const result = await sampleDataManager.installSampleData({ sampleType, esClient });
 
-      expect(mockIndexManager.deleteIndex).toHaveBeenCalledWith({
+      expect(mockIndexManager.hasIndex).toHaveBeenCalledWith({
         indexName: expectedIndexName,
         esClient,
       });
@@ -162,12 +164,6 @@ describe('SampleDataManager', () => {
       );
     });
 
-    it('should remove existing data before installation', async () => {
-      await sampleDataManager.installSampleData({ sampleType, esClient });
-
-      expect(mockIndexManager.deleteIndex).toHaveBeenCalled();
-    });
-
     it('should call cleanup when artifact preparation fails', async () => {
       const error = new Error('Artifact preparation failed');
       mockArtifactManager.prepareArtifact.mockRejectedValue(error);
@@ -209,7 +205,7 @@ describe('SampleDataManager', () => {
         indexName: expectedIndexName,
         esClient,
       });
-      expect(mockIndexManager.deleteIndex).toHaveBeenCalledTimes(2); // Once in removeSampleData, once in error handler
+      expect(mockIndexManager.deleteIndex).toHaveBeenCalled();
     });
 
     it('should handle different sample types correctly', async () => {
@@ -227,6 +223,22 @@ describe('SampleDataManager', () => {
         esClient,
       });
     });
+
+    it('should not install anything if index already exists', async () => {
+      mockIndexManager.hasIndex.mockResolvedValue(true);
+
+      const result = await sampleDataManager.installSampleData({ sampleType, esClient });
+
+      expect(mockIndexManager.hasIndex).toHaveBeenCalledWith({
+        indexName: expectedIndexName,
+        esClient,
+      });
+      expect(result).toBe(expectedIndexName);
+      expect(mockArtifactManager.prepareArtifact).not.toHaveBeenCalled();
+      expect(mockIndexManager.createAndPopulateIndex).not.toHaveBeenCalled();
+      expect(mockIndexManager.deleteIndex).not.toHaveBeenCalled();
+      expect(mockArtifactManager.cleanup).toHaveBeenCalled();
+    });
   });
 
   describe('removeSampleData', () => {
@@ -260,23 +272,21 @@ describe('SampleDataManager', () => {
     const expectedIndexName = 'kibana_sample_data_kibana';
 
     it('should return installed status when index exists', async () => {
-      esClient.indices.exists.mockResolvedValue(true);
+      mockIndexManager.hasIndex.mockResolvedValue(true);
 
       const result = await sampleDataManager.getSampleDataStatus({ sampleType, esClient });
 
-      expect(esClient.indices.exists).toHaveBeenCalledWith({ index: expectedIndexName });
       expect(result).toEqual({
         status: 'installed',
         indexName: expectedIndexName,
       });
     });
 
     it('should return uninstalled status when index does not exist', async () => {
-      esClient.indices.exists.mockResolvedValue(false);
+      mockIndexManager.hasIndex.mockResolvedValue(false);
 
       const result = await sampleDataManager.getSampleDataStatus({ sampleType, esClient });
 
-      expect(esClient.indices.exists).toHaveBeenCalledWith({ index: expectedIndexName });
       expect(result).toEqual({
         status: 'uninstalled',
         indexName: undefined,
@@ -285,7 +295,7 @@ describe('SampleDataManager', () => {
 
     it('should handle elasticsearch client errors gracefully', async () => {
       const error = new Error('Elasticsearch error');
-      esClient.indices.exists.mockRejectedValue(error);
+      mockIndexManager.hasIndex.mockRejectedValue(error);
 
       const result = await sampleDataManager.getSampleDataStatus({ sampleType, esClient });
 
@@ -312,17 +322,10 @@ describe('SampleDataManager', () => {
       expect(indexName).toBe('kibana_sample_data_kibana');
 
       // Check status after installation
-      esClient.indices.exists.mockResolvedValue(true);
+      mockIndexManager.hasIndex.mockResolvedValue(true);
       status = await sampleDataManager.getSampleDataStatus({ sampleType, esClient });
       expect(status.status).toBe('installed');
       expect(status.indexName).toBe('kibana_sample_data_kibana');
-
-      // Remove sample data
-      await sampleDataManager.removeSampleData({ sampleType, esClient });
-      expect(mockIndexManager.deleteIndex).toHaveBeenCalledWith({
-        indexName: 'kibana_sample_data_kibana',
-        esClient,
-      });
     });
   });
 });

x-pack/platform/plugins/shared/sample_data_ingest/server/services/sample_data_manager/sample_data_manager.ts

@@ -26,6 +26,7 @@ export class SampleDataManager {
   private readonly log: Logger;
   private readonly artifactManager: ArtifactManager;
   private readonly indexManager: IndexManager;
+  private isInstalling: boolean = false;
 
   constructor({
     artifactsFolder,
@@ -64,7 +65,12 @@ export class SampleDataManager {
     const indexName = getSampleDataIndexName(sampleType);
 
     try {
-      await this.removeSampleData({ sampleType, esClient });
+      if ((await this.indexManager.hasIndex({ indexName, esClient })) || this.isInstalling) {
+        this.log.warn(`Sample data already installed for [${sampleType}]`);
+        return indexName;
+      }
+
+      this.isInstalling = true;
 
       const {
         archive: artifactsArchive,
@@ -97,6 +103,7 @@ export class SampleDataManager {
       }
 
       await this.artifactManager.cleanup();
+      this.isInstalling = false;
     }
   }
 
@@ -120,10 +127,10 @@ export class SampleDataManager {
   }): Promise<StatusResponse> {
     const indexName = getSampleDataIndexName(sampleType);
     try {
-      const isIndexExists = await esClient.indices.exists({ index: indexName });
+      const hasIndex = await this.indexManager.hasIndex({ indexName, esClient });
       return {
-        status: isIndexExists ? 'installed' : 'uninstalled',
-        indexName: isIndexExists ? indexName : undefined,
+        status: hasIndex ? 'installed' : 'uninstalled',
+        indexName: hasIndex ? indexName : undefined,
       };
     } catch (error) {
       this.log.warn(`Failed to check sample data status for [${sampleType}]: ${error.message}`);