Fix a bug in LockBreakerConnection #3509
Open
+47
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason it is returned as a string, even though the return type of the PG function pg_backend_pid() is integer, is because Postgrex.ReplicationConnection uses simply query protocol. Hence the explicit type conversion in our Elixir code.
The way the unit test was ignoring the exit reason for the
LockBreakerConnection process was masking a bug in the code. Before the
explicit conversion of pg_backend_pid's value to integer, the exit
reason in the test was
{:function_clause,
[
{Electric.Postgres.LockBreakerConnection, :lock_breaker_query,
["electric_test_slot_d7f423cc8759", "16492",
"NXmQhg ~ test doesn't break the lock if it's taken from expe"],
[file: ~c"lib/electric/postgres/lock_breaker_connection.ex", line: 104]},
{Electric.Postgres.LockBreakerConnection, :handle_info, 2,
[file: ~c"lib/electric/postgres/lock_breaker_connection.ex", line: 80]},
{Postgrex.SimpleConnection, :handle, 5,
[file: ~c"lib/postgrex/simple_connection.ex", line: 438]},
{:gen_statem, :loop_state_callback, 11,
[file: ~c"gen_statem.erl", line: 3750]},
{:proc_lib, :init_p_do_apply, 3, [file: ~c"proc_lib.erl", line: 333]}
]}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3509 +/- ##
==========================================
+ Coverage 75.20% 75.31% +0.10%
==========================================
Files 51 51
Lines 2743 2743
Branches 409 405 -4
==========================================
+ Hits 2063 2066 +3
+ Misses 678 675 -3
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3506.