Stop reconnection attempts during shutdown #138
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t discovers a disconnect Sometimes this reconnect loop will be entered during shutdown, this allows the client to prevent the loop for running the default ten iterations if the calling app knows that it does not need reconnection, and wants more control during shutdown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes here:
When a conversation is ended, its possible that we are still stuck in the init message retry
loop. This will let us abort out of that loop, and handle Task cancelation so if the calling
task is canceled we will end the loop.
LiveKit will attempt to reconnect ten times by default when it discovers a disconect. This
can happen on startup and shutdown, and means a long delay until we can give user feedback
that the connection has failed. By passing in the reconnect attempts, we allow the calling
code to control this.
Commits: