Switch `font-lock-warning-face' to a non-warning face.

[cloudchin]

Howdy!

(defface helm-descbinds-key '((t :box t))
  "Face for keys in helm-descbinds.")

(defface helm-descbinds-binding '((t :inherit font-lock-warning-face))
  "Face for bindings in helm-descbinds.")

A quick switch to default fixes it.

vs my existing helmized describe-variable:

Thank you for helm.

[thierryvolpiatto]

cloudchin ***@***.***> writes:

1. ( ) text/plain (*) text/html Howdy! image.png (view on web) (defface helm-descbinds-key '((t :box t)) "Face for keys in helm-descbinds.") (defface helm-descbinds-binding '((t :inherit font-lock-warning-face)) "Face for bindings in helm-descbinds.") A quick switch to default fixes it. image.png (view on web)

Hello! Sorry but I don't understand what the issue is, could you elaborate? Thanks.

vs my existing helmized describe-variable: image.png (view on web)

Unrelated (I think) but if you want more details use (setq completions-detailed t) or M-x helm-apropos.

…

Thank you for helm. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.*Message ID: ***@***.***>

-- Thierry

[cloudchin]

Thanks -- not a bad feature, but it does have the same issue as I have with helm-descbinds in that it's using an inappropriate font lock face font-lock-warning-face. Why would they be marked to provide Warning-level of syntactics? Why is syntactic highlighting needed on them at all?

In descbinds case, can quickly swap

(defface helm-descbinds-binding '((t :inherit font-lock-warning-face))
   "...")

to

(defface helm-descbinds-binding '((t :inherit default))
   "...")

which brings color/text of non-matched results in line with other helm sessions.

Compare my first screen shot to typical helm sessions:
M-x invocation - notice highlighting is only done on my substr

helm-apropos prompt - clean

helm-occur - more proper use of syntactic highlighting

helm-ff faces are bit more busy but they at least have syntactic relevance.

[thierryvolpiatto]

cloudchin ***@***.***> writes:

Thanks -- not a bad feature, but it does have the same issue as I have with helm-descbinds in that it's using an inappropriate font lock face font-lock-warning-face. Why would they be marked to provide Warning-level of syntactics?

It is common to use font-lock-* faces for other purpose than syntactic meaning. If you think it is better to use 'default face in some places I could modify this, let me know the faces you want to modify (or even better provide a PR ;-)) Thanks.

…

-- Thierry

[cloudchin]

Thanks. I'm a hobbyist that isn't familiar with how to do PR's with GitHub but honestly would be cool to figure that out. Allow me a bit to review that and some of the face's helm is using and I'll see if I can submit something this week.

[thierryvolpiatto]

cloudchin ***@***.***> writes:

1. ( ) text/plain (*) text/html Thanks. I'm a hobbyist that isn't familiar with how to do PR's with GitHub but honestly would be cool to figure that out. Allow me a bit to review that and some of the face's helm is using and I'll see if I can submit something this week.

Sure, take your time and don't hesitate to ask for help if needed.

…

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.*Message ID: ***@***.***>

-- Thierry