Make `helm-org-insert-link-to-heading-at-marker` insert id when the selected heading has one

[rodrigo-morales-1]

Given that org-id.el is a native package and some users use this feature for creating a permanent link to a heading, I think it would be useful that helm-org-insert-link-to-heading-at-marker consider the ID property for referencing a selected heading. The current behavior is to use the heading title.

[rodrigo-morales-1]

I guess it would be better if there were a defcustom that would allow the user to define whether helm-org-insert-link-to-headint-at-marker use ids or not, so that helm would create the ID in the scenario that the selected heading doesn't have one.

[alphapapa]

I haven't looked at the code in question, but we should probably be using Org's built-in link-creating functions (i.e. org-store-link), which should take the existing option org-id-link-to-org-use-id into account. We probably shouldn't be doing this manually and adding a Helm-specific option.

[rodrigo-morales-1]

@alphapapa I agree with you, using org-store-link (your idea) would be better than creating a defcustom (my idea) for this.

For those interested, here's the relevant part of the source code:

The function helm-org-headings-actions contains helm-org-insert-link-to-heading-at-marker.

helm-org/helm-org.el

Lines 98 to 105 in d67186d

	(defcustom helm-org-headings-actions
	'(("Go to heading" . helm-org-goto-marker)
	("Open in indirect buffer `C-c i'" . helm-org--open-heading-in-indirect-buffer)
	("Refile heading(s) (marked-to-selected|current-to-selected) `C-c w`" . helm-org--refile-heading-to)
	("Insert link to this heading `C-c l`" . helm-org-insert-link-to-heading-at-marker))
	"Default actions alist for `helm-source-org-headings-for-files'."
	:group 'helm-org
	:type '(alist :key-type string :value-type function))

The function helm-org-insert-link-to-heading-at-marker uses org-insert-link.

helm-org/helm-org.el

Lines 376 to 384 in d67186d

	(defun helm-org-insert-link-to-heading-at-marker (marker)
	"Insert link to heading at MARKER position."
	(with-current-buffer (marker-buffer marker)
	(let ((heading-name (save-excursion (goto-char (marker-position marker))
	(nth 4 (org-heading-components))))
	(file-name (buffer-file-name)))
	(with-helm-current-buffer
	(org-insert-link
	file-name (concat "file:" file-name "::*" heading-name))))))

[alphapapa]

Thanks. I don't use this feature, myself, so I'll let someone else propose a patch. Please feel free to tag my username to get my attention on this again; notifications on repos I don't own tend to get lost.

[rodrigo-morales-1]

@alphapapa I've created a pull request: #26