Skip to content

Commit 2f1c78e

Browse files
committed
grammar and spelling
1 parent 22607ee commit 2f1c78e

File tree

8 files changed

+12
-12
lines changed

8 files changed

+12
-12
lines changed

tests/integration/components/guide-section/subsection-test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ module('Integration | Component | guide-section/subsection', function (hooks) {
6161
assert
6262
.dom('[data-test-field="Subsection Description"]')
6363
.includesText(
64-
'Examples here are shown for apps that use JSON:API. Apps using other paradigms should use the builders for REST or ActiveRecord if applicable, or author their own (or a new community lib!) if not.'
64+
'Examples here are shown for apps that use JSON:API. Apps using other paradigms should use the builders for REST or ActiveRecord if applicable, or author their own (or a new community library!) if not.'
6565
);
6666

6767
const emberClassic = this.element.querySelector(
@@ -97,7 +97,7 @@ module('Integration | Component | guide-section/subsection', function (hooks) {
9797
assert
9898
.dom('[data-test-field="Subsection Description"]')
9999
.includesText(
100-
'To create a new record using Ember Data you should use createRecord request and attach "body" to it. In case of JSON:API backend - you can use serializeResources request utility.'
100+
'To create a new record using Ember Data, you should use createRecord request and attach "body" to it. Use serializeResources request utility when working with a JSON:API backend.'
101101
);
102102

103103
const emberClassic = this.element.querySelector(
@@ -133,7 +133,7 @@ module('Integration | Component | guide-section/subsection', function (hooks) {
133133
assert
134134
.dom('[data-test-field="Subsection Description"]')
135135
.includesText(
136-
'To delete an existing record using Ember Data you should use deleteRecord builder to issue the request.'
136+
'To delete an existing record using Ember Data, you should use deleteRecord builder to issue the request.'
137137
);
138138

139139
const emberClassic = this.element.querySelector(

translations/adapters/path-for-type/en-us.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ title: Use request builders instead of pathForType
22
description: >
33
To modify a URL for a request you can use the '<code>'resourcePath'</code>' option for every request builder. Default configuration for '<code>'JSON:API'</code>', '<code>'REST'</code>', and '<code>'ActiveRecord'</code>' builders will be provided by EmberData.
44
<br />
5-
We recommend creating your own utility file with request builders that suite your backend's needs.
5+
We recommend creating your own utility file with request builders that suit your backend's needs.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
title: deleteRecord
2-
description: To delete an existing record using Ember Data you should use <code>deleteRecord</code> builder to issue the request.
2+
description: To delete an existing record using Ember Data, you should use <code>deleteRecord</code> builder to issue the request.
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
title: findAll
22
description: |
3-
There is no direct replacement for <code>findAll</code>, you can use <code>query</code> without extra options instead. Here is how to achieve exact <code>findAll</code> behavior:
4-
We discourage using <code>peekAll</code>. When you made a request, you need to guarantee that everything you requested is part of response you get back.
3+
There is no direct replacement for <code>findAll</code>, so you can use <code>query</code> with extra options instead. Here's how to achieve exact <code>findAll</code> behavior:
4+
We discourage using <code>peekAll</code>, but it is currently the best way to guarantee that everything you requested is part of the response you get back.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
title: findRecord
22
description: |
3-
Examples here are shown for apps that use JSON:API. Apps using other paradigms should use the builders for REST or ActiveRecord if applicable, or author their own (or a new community lib!) if not.
3+
Examples here are shown for apps that use JSON:API. Apps using other paradigms should use the builders for REST or ActiveRecord if applicable, or author their own (or a new community library!) if not.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
title: query
2-
description: The <code>query</code> just moved out from being on <code>Store</code> public interface to builders.
2+
description: The <code>query</code> has moved from the <code>Store</code> public interface to builders.

translations/serializers/general/en-us.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ description: |
88
<br />
99
Similarly, the methods '<code>'adapterFor'</code>' and '<code>'serializerFor'</code>' will not be deprecated until at least 6.0; however, it should no longer be assumed that an application has an adapter or serializer at all.
1010
<br />
11-
Serializers previously was used to accomplish two main things: serialization and normalization.
11+
Serializers previously were used to accomplish two main things: serialization and normalization.
1212
<br />
1313
Normalization is now done in handlers, before returning the response.
1414
<br />
15-
Serialization can be done in handler, but we encourage application developers to do it in request builder.
15+
Serialization can be done in a handler, but we encourage application developers to do it in request builder.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
title: createRecord
2-
description: To create a new record using Ember Data you should use <code>createRecord</code> request and attach <code>"body"</code> to it. In case of JSON:API backend - you can use <code>serializeResources</code> request utility.
2+
description: To create a new record using Ember Data, you should use a <code>createRecord</code> request and attach <code>"body"</code> to it. Use the <code>serializeResources</code> request utility when working with a JSON:API backend.

0 commit comments

Comments
 (0)