Skip to content

Commit 3d219c8

Browse files
authored
Merge pull request #277 from ember-learn/prettier
apply prettier to all our hbs files
2 parents d7f9ca1 + 07e34e9 commit 3d219c8

File tree

8 files changed

+58
-48
lines changed

8 files changed

+58
-48
lines changed

.prettierignore

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,6 @@
77
# mirage data
88
/mirage/data
99

10-
# tempoariliy ignore hbs files
11-
*.hbs
12-
1310
# misc
1411
/coverage/
1512
!.*

app/components/filter-menu.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@
1111
{{filterName}}
1212
</LinkTo>
1313
{{/each}}
14-
</div>
14+
</div>

app/components/github-label.hbs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
<span
2-
local-class="label"
3-
style={{this.styleForLabel}}
4-
>
1+
<span local-class="label" style={{this.styleForLabel}}>
52
{{remove-emoji-shortcode @label}}
63
</span>

app/templates/application.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@
66
{{outlet}}
77
</main>
88

9-
<EsFooter />
9+
<EsFooter />

app/templates/index.hbs

Lines changed: 38 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<div class="bg-shape-boxes pt-5" local-class="container">
22
<div class="mb-4 pt-4" local-class="header-container">
3-
<img alt="" src="../images/ember-help-wanted-logo.svg">
3+
<img alt="" src="../images/ember-help-wanted-logo.svg" />
44
<h1 class="text-hero-xl" local-class="header">
55
Ember Help Wanted
66
</h1>
@@ -25,7 +25,8 @@
2525
@title={{githubRepository.name}}
2626
>
2727
<p>
28-
Forks: {{githubRepository.forksCount}}
28+
Forks:
29+
{{githubRepository.forksCount}}
2930
</p>
3031
</EsLinkCard>
3132
{{/each}}
@@ -39,45 +40,58 @@
3940
</h2>
4041

4142
<p local-class="paragraph">
42-
This app is designed to help community members find issues in the Ember ecosystem that are requesting some extra
43-
help! The goal would be for this to work well for project nights for meetups, conferences and anyone else
44-
interested in hacking on various projects while also helping the main Ember repositories get much needed help
45-
with issues.
43+
This app is designed to help community members find issues in the Ember
44+
ecosystem that are requesting some extra help! The goal would be for
45+
this to work well for project nights for meetups, conferences and anyone
46+
else interested in hacking on various projects while also helping the
47+
main Ember repositories get much needed help with issues.
4648
</p>
4749

4850
<h3>Big Picture</h3>
4951

5052
<p local-class="paragraph">
51-
To accomplish this, we use a <a href="https://github.com/ember-learn/ember-help-wanted-server">Node backend</a>
52-
that receives Github webhook notifications about issues across a number of Ember projects. The backend will
53-
filter those issues and store them to act as our "pool" of potential issues that potential contributors can work
54-
on.
53+
To accomplish this, we use a
54+
<a href="https://github.com/ember-learn/ember-help-wanted-server">Node
55+
backend</a>
56+
that receives Github webhook notifications about issues across a number
57+
of Ember projects. The backend will filter those issues and store them
58+
to act as our "pool" of potential issues that potential contributors can
59+
work on.
5560
</p>
5661

5762
<p local-class="paragraph">
58-
Those issues will then surface in this Ember app, where they can be searched and filtered in various ways as
59-
each potential contributor desires. We may add some level of curation to the issues (whether that is needed is
60-
still to be determined) or in other ways editorialize as issues show up in the app.
63+
Those issues will then surface in this Ember app, where they can be
64+
searched and filtered in various ways as each potential contributor
65+
desires. We may add some level of curation to the issues (whether that
66+
is needed is still to be determined) or in other ways editorialize as
67+
issues show up in the app.
6168
</p>
6269

6370
<p local-class="paragraph">
64-
Meetup organizers (and contributor workshops at various Ember conferences) can also use this as a tool to sort
65-
through issues and pick subsets for their meetings. For example, if a Meetup group wants to help its members
66-
learn more about Ember Data, a meetup organizer could go through the existing pool of issues and cherry-pick
67-
5-10 issues for folks to focus on for that evening that would help with that. This tool could be used as a
68-
foundation for running the Contributors Workshop that occurs each year at EmberConf.
71+
Meetup organizers (and contributor workshops at various Ember
72+
conferences) can also use this as a tool to sort through issues and pick
73+
subsets for their meetings. For example, if a Meetup group wants to help
74+
its members learn more about Ember Data, a meetup organizer could go
75+
through the existing pool of issues and cherry-pick 5-10 issues for
76+
folks to focus on for that evening that would help with that. This tool
77+
could be used as a foundation for running the Contributors Workshop that
78+
occurs each year at EmberConf.
6979
</p>
7080

7181
<p local-class="paragraph">
72-
Long-term, we are considering ways to make this easily findable by anyone who wants to contribute to Ember-
73-
tweeting out major new issues, or in other ways that communicate key pieces of info to the Ember community. We
74-
could potentially use it as a way of posting "maintainer wanted" messages as well. Do you have more ideas? Let
75-
us know!
82+
Long-term, we are considering ways to make this easily findable by
83+
anyone who wants to contribute to Ember- tweeting out major new issues,
84+
or in other ways that communicate key pieces of info to the Ember
85+
community. We could potentially use it as a way of posting "maintainer
86+
wanted" messages as well. Do you have more ideas? Let us know!
7687
</p>
7788

7889
<p local-class="paragraph">
79-
To learn more, visit <a href="https://github.com/ember-learn/ember-help-wanted">ember-help-wanted GitHub repo</a>.
90+
To learn more, visit
91+
<a
92+
href="https://github.com/ember-learn/ember-help-wanted"
93+
>ember-help-wanted GitHub repo</a>.
8094
</p>
8195
</div>
8296
</div>
83-
</div>
97+
</div>

app/templates/issues.hbs

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,7 @@
33
<FilterMenu />
44

55
<form {{on "submit" this.filterIssues}}>
6-
<label
7-
for="search-input-issues"
8-
local-class="search-label"
9-
>
6+
<label for="search-input-issues" local-class="search-label">
107
Keyword
118
</label>
129

@@ -16,7 +13,7 @@
1613
local-class="search-input"
1714
type="text"
1815
value={{this.keyword}}
19-
{{on "input" this.updateKeyword}}
16+
{{on "input" this.updateKeyword}}
2017
/>
2118

2219
<EsButton
@@ -29,7 +26,10 @@
2926
{{#if this.label}}
3027
<div local-class="label-filter-container">
3128
<p>
32-
In addition, look for issues with the label <span local-class="label-filter">{{remove-emoji-shortcode this.label}}</span>.
29+
In addition, look for issues with the label
30+
<span local-class="label-filter">{{remove-emoji-shortcode
31+
this.label
32+
}}</span>.
3333
</p>
3434

3535
<EsButton
@@ -47,7 +47,8 @@
4747
</form>
4848

4949
<p class="text-sm" local-class="num-results-found">
50-
{{@model.length}} issues displayed
50+
{{@model.length}}
51+
issues displayed
5152
</p>
5253
</section>
5354

@@ -96,8 +97,8 @@
9697
target="_blank"
9798
>
9899
{{githubIssue.repositoryName}}
99-
</a>,
100-
updated <b>{{time-from-now githubIssue.updatedAt}}</b>
100+
</a>, updated
101+
<b>{{time-from-now githubIssue.updatedAt}}</b>
101102
</p>
102103

103104
{{#each githubIssue.labels as |label|}}
@@ -118,4 +119,4 @@
118119
{{/each}}
119120
</ul>
120121
</div>
121-
</div>
122+
</div>

app/templates/loading.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,4 @@
88
<div local-class="sk-cube sk-cube7"></div>
99
<div local-class="sk-cube sk-cube8"></div>
1010
<div local-class="sk-cube sk-cube9"></div>
11-
</div>
11+
</div>

app/templates/pull-requests.hbs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
1-
{{page-title 'Pull Requests (' @model.length ')'}}
1+
{{page-title "Pull Requests (" @model.length ")"}}
22
{{outlet}}
33

4-
<div class='container' local-class='body-container'>
5-
<h2 class='text-xl pb-3'>
6-
{{ @model.length }} open pull requests
4+
<div class="container" local-class="body-container">
5+
<h2 class="text-xl pb-3">
6+
{{@model.length}}
7+
open pull requests
78
</h2>
89
<table>
910
<thead>

0 commit comments

Comments
 (0)