Skip to content

Commit 9755c90

Browse files
authored
Merge pull request #275 from MehulKChaudhari/migrate-to-ember-scoped-css
Migrate to ember scoped css
2 parents f1f4f53 + f83ea7e commit 9755c90

File tree

13 files changed

+486
-379
lines changed

13 files changed

+486
-379
lines changed

app/components/filter-menu.hbs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
1-
<div local-class="container">
1+
<div class="container">
22
{{#each this.filterNames as |filterName|}}
33
<LinkTo
4-
class="es-button"
4+
class="es-button link"
55
data-test-link={{filterName}}
6-
local-class="link"
76
@model={{filterName}}
87
@query={{hash query=""}}
98
@route="issues"

app/components/github-label.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
<span local-class="label" style={{this.styleForLabel}}>
1+
<span class="label" style={{this.styleForLabel}}>
22
{{remove-emoji-shortcode @label}}
33
</span>

app/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,4 @@
2121

2222
{{content-for "body-footer"}}
2323
</body>
24-
</html>
24+
</html>

app/styles/index.css renamed to app/templates/index.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
.container {
1+
.index-container {
22
background-color: var(--color-gray-900);
33
height: 100%;
44
}

app/templates/index.hbs

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
<div class="bg-shape-boxes pt-5" local-class="container">
2-
<div class="mb-4 pt-4" local-class="header-container">
1+
<div class="bg-shape-boxes pt-5 index-container">
2+
<div class="mb-4 pt-4 header-container">
33
<img alt="" src="../images/ember-help-wanted-logo.svg" />
4-
<h1 class="text-hero-xl" local-class="header">
4+
<h1 class="text-hero-xl header">
55
Ember Help Wanted
66
</h1>
77

88
<FilterMenu />
99
</div>
1010

11-
<div class="bg-light-muted" local-class="body-container">
11+
<div class="bg-light-muted body-container">
1212
<div class="container">
1313
<h2 class="text-xl pb-3">
1414
Repositories with help-wanted issues
@@ -18,9 +18,8 @@
1818
<ul class="list-unstyled layout">
1919
{{#each @model as |githubRepository|}}
2020
<EsLinkCard
21-
class="lg:col-3 bg-dark"
21+
class="lg:col-3 bg-dark link-card"
2222
data-test-github-repository={{githubRepository.name}}
23-
local-class="link-card"
2423
@href="{{githubRepository.htmlUrl}}/issues?q=is%3Aissue+is%3Aopen+label%3A%22Help+Wanted%22+sort%3Acreate-date"
2524
@title={{githubRepository.name}}
2625
>
@@ -39,7 +38,7 @@
3938
Improving the contributor experience
4039
</h2>
4140

42-
<p local-class="paragraph">
41+
<p class="paragraph">
4342
This app is designed to help community members find issues in the Ember
4443
ecosystem that are requesting some extra help! The goal would be for
4544
this to work well for project nights for meetups, conferences and anyone
@@ -49,7 +48,7 @@
4948

5049
<h3>Big Picture</h3>
5150

52-
<p local-class="paragraph">
51+
<p class="paragraph">
5352
To accomplish this, we use a
5453
<a href="https://github.com/ember-learn/ember-help-wanted-server">Node
5554
backend</a>
@@ -59,15 +58,15 @@
5958
work on.
6059
</p>
6160

62-
<p local-class="paragraph">
61+
<p class="paragraph">
6362
Those issues will then surface in this Ember app, where they can be
6463
searched and filtered in various ways as each potential contributor
6564
desires. We may add some level of curation to the issues (whether that
6665
is needed is still to be determined) or in other ways editorialize as
6766
issues show up in the app.
6867
</p>
6968

70-
<p local-class="paragraph">
69+
<p class="paragraph">
7170
Meetup organizers (and contributor workshops at various Ember
7271
conferences) can also use this as a tool to sort through issues and pick
7372
subsets for their meetings. For example, if a Meetup group wants to help
@@ -78,15 +77,15 @@
7877
occurs each year at EmberConf.
7978
</p>
8079

81-
<p local-class="paragraph">
80+
<p class="paragraph">
8281
Long-term, we are considering ways to make this easily findable by
8382
anyone who wants to contribute to Ember- tweeting out major new issues,
8483
or in other ways that communicate key pieces of info to the Ember
8584
community. We could potentially use it as a way of posting "maintainer
8685
wanted" messages as well. Do you have more ideas? Let us know!
8786
</p>
8887

89-
<p local-class="paragraph">
88+
<p class="paragraph">
9089
To learn more, visit
9190
<a
9291
href="https://github.com/ember-learn/ember-help-wanted"
File renamed without changes.

app/templates/issues.hbs

Lines changed: 14 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,41 +1,41 @@
11
{{page-title "Issues"}}
2-
<section class="container" local-class="header-container">
2+
<section class="container header-container">
33
<FilterMenu />
44

55
<form {{on "submit" this.filterIssues}}>
6-
<label for="search-input-issues" local-class="search-label">
6+
<label for="search-input-issues" class="search-label">
77
Keyword
88
</label>
99

1010
<input
1111
id="search-input-issues"
1212
data-test-field="Keyword"
13-
local-class="search-input"
13+
class="search-input"
1414
type="text"
1515
value={{this.keyword}}
1616
{{on "input" this.updateKeyword}}
1717
/>
1818

1919
<EsButton
2020
data-test-button="Search"
21-
local-class="search-button"
21+
class="search-button"
2222
@label="Search"
2323
@type="submit"
2424
/>
2525

2626
{{#if this.label}}
27-
<div local-class="label-filter-container">
27+
<div class="label-filter-container">
2828
<p>
2929
In addition, look for issues with the label
30-
<span local-class="label-filter">{{remove-emoji-shortcode
30+
<span class="label-filter">{{remove-emoji-shortcode
3131
this.label
3232
}}</span>.
3333
</p>
3434

3535
<EsButton
3636
aria-label={{this.clearMessage}}
3737
data-test-button="Clear Filter"
38-
local-class="clear-label-filter-button"
38+
class="clear-label-filter-button"
3939
title={{this.clearMessage}}
4040
@label="Clear Filter"
4141
@onClicked={{fn (mut this.label) null}}
@@ -46,24 +46,21 @@
4646
{{/if}}
4747
</form>
4848

49-
<p class="text-sm" local-class="num-results-found">
49+
<p class="text-sm num-results-found">
5050
{{@model.length}}
5151
issues displayed
5252
</p>
5353
</section>
5454

55-
<div class="container" local-class="body-container">
55+
<div class="container body-container">
5656
<h2 class="text-xl pb-3">
5757
Issues that could use your help!
5858
</h2>
5959

6060
<div class="row">
6161
<ul class="list-unstyled layout">
6262
{{#each this.githubIssuesSorted as |githubIssue|}}
63-
<EsCard
64-
data-test-github-issue={{githubIssue.number}}
65-
local-class="card"
66-
>
63+
<EsCard data-test-github-issue={{githubIssue.number}} class="card">
6764
<header>
6865
<h3 class="text-lg">
6966
<a
@@ -76,11 +73,8 @@
7673
</a>
7774
</h3>
7875

79-
<div local-class="github-issue-number-container">
80-
<p
81-
data-test-field="Issue Number"
82-
local-class="github-issue-number"
83-
>
76+
<div class="github-issue-number-container">
77+
<p data-test-field="Issue Number" class="github-issue-number">
8478
#{{githubIssue.number}}
8579
</p>
8680
</div>
@@ -92,7 +86,7 @@
9286
<a
9387
data-test-field="Repository Name"
9488
href={{githubIssue.repositoryHtml}}
95-
local-class="github-repository-name"
89+
class="github-repository-name"
9690
rel="noopener noreferrer"
9791
target="_blank"
9892
>
@@ -104,7 +98,7 @@
10498
{{#each githubIssue.labels as |label|}}
10599
<button
106100
data-test-button={{label.name}}
107-
local-class="github-label-button"
101+
class="github-label-button"
108102
type="button"
109103
{{on "click" (fn (mut this.label) label.name)}}
110104
>
File renamed without changes.

app/templates/loading.hbs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
<div local-class="sk-cube-grid">
2-
<div local-class="sk-cube sk-cube1"></div>
3-
<div local-class="sk-cube sk-cube2"></div>
4-
<div local-class="sk-cube sk-cube3"></div>
5-
<div local-class="sk-cube sk-cube4"></div>
6-
<div local-class="sk-cube sk-cube5"></div>
7-
<div local-class="sk-cube sk-cube6"></div>
8-
<div local-class="sk-cube sk-cube7"></div>
9-
<div local-class="sk-cube sk-cube8"></div>
10-
<div local-class="sk-cube sk-cube9"></div>
1+
<div class="sk-cube-grid">
2+
<div class="sk-cube sk-cube1"></div>
3+
<div class="sk-cube sk-cube2"></div>
4+
<div class="sk-cube sk-cube3"></div>
5+
<div class="sk-cube sk-cube4"></div>
6+
<div class="sk-cube sk-cube5"></div>
7+
<div class="sk-cube sk-cube6"></div>
8+
<div class="sk-cube sk-cube7"></div>
9+
<div class="sk-cube sk-cube8"></div>
10+
<div class="sk-cube sk-cube9"></div>
1111
</div>

app/templates/pull-requests.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{{page-title "Pull Requests (" @model.length ")"}}
22
{{outlet}}
33

4-
<div class="container">
4+
<div class="container body-container">
55
<h2 class="text-xl pb-3">
66
{{@model.length}}
77
open pull requests

0 commit comments

Comments
 (0)