Fixes path separator issues and adds default value for packge-feed-url argument (#8)

Author: JamesDawson

.vscode/launch.json

@@ -0,0 +1,20 @@
+{
+    // Use IntelliSense to learn about possible attributes.
+    // Hover to view descriptions of existing attributes.
+    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
+    "version": "0.2.0",
+    "configurations": [
+        {
+            "name": ".NET Core Launch",
+            "type": "coreclr",
+            "request": "launch",
+            "program": "${workspaceRoot}/Solutions/Endjin.SemVer.DotNetApi.Cli/bin/Debug/netcoreapp3.1/nupkgversion",
+            "args": [
+                "${workspaceRoot}"
+            ],
+            "cwd": "${workspaceRoot}",
+            "stopAtEntry": false,
+            "console": "internalConsole"
+        },
+    ]
+}

Solutions/Endjin.SemVer.DotNetApi.Cli/Endjin/SemVer/DotNetApi/Cli/CommandLineParser.cs

@@ -69,7 +69,7 @@ RootCommand Root()
                     Arity = ArgumentArity.ExactlyOne,
                 });
 
-                cmd.AddArgument(new Argument<Uri>
+                cmd.AddArgument(new Argument<Uri>(getDefaultValue: () => new Uri("https://api.nuget.org/v3/index.json") )
                 {
                     Name = "package-feed-url",
                     Description = "Uri of the package feed to compare against.",

Solutions/Endjin.SemVer.DotNetApi/Endjin/SemVer/DotNetApi/PackageComparison/PackageCollectionComparisonOrchestrator.cs

@@ -250,9 +250,9 @@ bool IsXmlDocFile(string name) =>
                     biggestChangeSeen = biggestChangeSeen.AtLeast(SemanticVersionChange.Minor);
                 }
 
-                string workingFolder = Path.Combine(Path.GetTempPath(), @"endjin\nupkgversion\" + Guid.NewGuid());
-                string predecessorFolder = workingFolder + @"\before";
-                string targetFolder = workingFolder + @"\after";
+                string workingFolder = Path.Combine(Path.GetTempPath(), "endjin", "nupkgversion", Guid.NewGuid().ToString());
+                string predecessorFolder = Path.Combine(workingFolder, "before");
+                string targetFolder = Path.Combine(workingFolder, "after");
 
                 try
                 {
@@ -268,8 +268,8 @@ bool IsXmlDocFile(string name) =>
                         if (libItem.EndsWith(".dll", StringComparison.OrdinalIgnoreCase))
                         {
                             Console.WriteLine(" Comparing " + libItem);
-                            string predecessorPath = predecessorFolder + "\\" + libItem;
-                            string targetPath = targetFolder + "\\" + libItem;
+                            string predecessorPath = Path.Combine(predecessorFolder, libItem);
+                            string targetPath = Path.Combine(targetFolder, libItem);
 
                             SemanticVersionChange changeForThisItem = CheckAssembliesForSemverChanges(predecessorPath, targetPath);
                             Console.WriteLine("  " + changeForThisItem);