Skip to content

Bugfix: On windows stderr was erroneously written to stdout #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2025
Merged

Bugfix: On windows stderr was erroneously written to stdout #429

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94cc53d
Stderr was erroneously written to stdout
sytsereitsma Aug 23, 2025
e57dc1d
Reuse the writer creation code
sytsereitsma Aug 23, 2025
de6b134
Merge branch 'main' into stdout_instead_of_stderr
sytsereitsma Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 12 additions & 27 deletions src/encode/writer/console.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,9 +319,13 @@ mod imp {
}

impl Writer {
pub fn stdout() -> Option<Writer> {
fn create_writer(inner_writer: StdWriter) -> Option<Writer> {
unsafe {
let handle = processenv::GetStdHandle(winbase::STD_OUTPUT_HANDLE);
let handle = match inner_writer {
StdWriter::Stdout(_) => processenv::GetStdHandle(winbase::STD_OUTPUT_HANDLE),
StdWriter::Stderr(_) => processenv::GetStdHandle(winbase::STD_ERROR_HANDLE),
};

if handle.is_null() || handle == handleapi::INVALID_HANDLE_VALUE {
return None;
}
Expand All @@ -336,7 +340,7 @@ mod imp {
handle,
defaults: info.wAttributes,
},
inner: StdWriter::stdout(),
inner: inner_writer,
};

match color_mode() {
Expand All @@ -346,31 +350,12 @@ mod imp {
}
}

pub fn stderr() -> Option<Writer> {
unsafe {
let handle = processenv::GetStdHandle(winbase::STD_ERROR_HANDLE);
if handle.is_null() || handle == handleapi::INVALID_HANDLE_VALUE {
return None;
}

let mut info = mem::zeroed();
if wincon::GetConsoleScreenBufferInfo(handle, &mut info) == 0 {
return None;
}

let writer = Writer {
console: RawConsole {
handle,
defaults: info.wAttributes,
},
inner: StdWriter::stdout(),
};
pub fn stdout() -> Option<Writer> {
Self::create_writer(StdWriter::stdout())
}

match color_mode() {
ColorMode::Auto | ColorMode::Always => Some(writer),
ColorMode::Never => None,
}
}
pub fn stderr() -> Option<Writer> {
Self::create_writer(StdWriter::stderr())
}

pub fn lock<'a>(&'a self) -> WriterLock<'a> {
Expand Down
Loading