This repository was archived by the owner on Jun 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Refactor ResourceMojo to get rid of GeneratorContextΒ #1528
Copy link
Copy link
Open
Labels
group/enricherEnricher relatedEnricher relatedstatus/never-stalePin this issue to get never marked as stale by stale-botPin this issue to get never marked as stale by stale-bottarget/JKubeImplementation to be performed in JKubeImplementation to be performed in JKube
Description
Right now we're referencing Generators during resource generation in ResourceMojo here:
fabric8-maven-plugin/plugin/src/main/java/io/fabric8/maven/plugin/mojo/build/ResourceMojo.java
Lines 902 to 930 in 19c3689
| private List<ImageConfiguration> getResolvedImages(List<ImageConfiguration> images, final Logger log) | |
| throws MojoExecutionException { | |
| List<ImageConfiguration> ret; | |
| ret = ConfigHelper.resolveImages( | |
| log, | |
| images, | |
| (ImageConfiguration image) -> imageConfigResolver.resolve(image, project, session), | |
| null, // no filter on image name yet (TODO: Maybe add this, too ?) | |
| (List<ImageConfiguration> configs) -> { | |
| try { | |
| GeneratorContext ctx = new GeneratorContext.Builder() | |
| .config(extractGeneratorConfig()) | |
| .project(project) | |
| .logger(log) | |
| .platformMode(mode) | |
| .strategy(buildStrategy) | |
| .useProjectClasspath(useProjectClasspath) | |
| .build(); | |
| return GeneratorManager.generate(configs, ctx, true); | |
| } catch (Exception e) { | |
| throw new IllegalArgumentException("Cannot extract generator: " + e, e); | |
| } | |
| }); | |
| Date now = getBuildReferenceDate(); | |
| storeReferenceDateInPluginContext(now); | |
| String minimalApiVersion = ConfigHelper.initAndValidate(ret, null /* no minimal api version */, | |
| new ImageNameFormatter(project, now), log); | |
| return ret; |
We need ImageConfiguration in order to extract image names and container ports while making pod template. Ideally ResourceMojo should not be aware of ImageConfiguration which should be referenced in BuildMojo. We should find a way to get of of Generators here. Maybe we can make this configuration option for enrichers, too(or think about other solutions). This for sure is less harming than blending in generators here.
devang-gaur
Metadata
Metadata
Assignees
Labels
group/enricherEnricher relatedEnricher relatedstatus/never-stalePin this issue to get never marked as stale by stale-botPin this issue to get never marked as stale by stale-bottarget/JKubeImplementation to be performed in JKubeImplementation to be performed in JKube