Skip to content

Commit 387a44b

Browse files
Yilei Yangfacebook-github-bot
authored andcommitted
Disable type checking on this internal Python library.
Summary: Why? It's generated and its content looks like ``` data = publish_from_yaml_impl_args_t.parse_raw(""" {"repo":"fb-runtime","package_name":"fb-platform010-cinder310-runtime","yaml_target":"fbcode//python/runtime/deploy/3.10.cinder:_IMAGE_EXPORT_FILE__platform010/packman.yml","run_as_root":false} """) ``` and it doesn't provide much value. When rpm.publish_from_yaml is used in a directory whose path isn't valid Python (example: [fbcode/python/runtime/deploy/3.10.cinder/TARGETS](https://www.internalfb.com/code/fbsource/fbcode/python/runtime/deploy/3.10.cinder/TARGETS), it will also fail because it tries to import the library: https://www.internalfb.com/intern/test/281475179465529 Test Plan: CI ``` buck targets fbcode//python/runtime/deploy/3.10.cinder: ``` no longer contains the `fbcode//python/runtime/deploy/3.10.cinder:fb-platform010-cinder310-runtime-bzl-args-type-checking` target. Reviewed By: vmagro Differential Revision: D70649826 fbshipit-source-id: ff9f04182889af2c9a9ce61e2a8f87f3b78b9857
1 parent 7bb13a7 commit 387a44b

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

antlir/bzl/shape.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -456,6 +456,7 @@ def _python_data(
456456
compatible_with = ["ovr_config//os:linux"],
457457
)
458458

459+
python_library_kwargs.setdefault("typing", False)
459460
python_library(
460461
name = name,
461462
compatible_with = ["ovr_config//os:linux"],

0 commit comments

Comments
 (0)