-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Server Prompt Templates #1792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server Prompt Templates #1792
Conversation
Summary of ChangesHello @paulb777, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a prototype for server-side prompt templates within the Firebase AI example application. It provides new UI screens and view models for generating content, images, and chat responses using predefined templates. This enhancement aims to demonstrate a more structured and reusable approach to interacting with generative AI models, although the chat template functionality is currently a work in progress. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds prototypes for using server prompt templates for content generation, Imagen, and Chat. The changes are well-structured, adding new screens and corresponding view models, and updating the main content view to navigate to them. My feedback focuses on improving code quality by removing commented-out code, avoiding force unwraps, and using constants for hardcoded strings to enhance maintainability.
firebaseai/GenerativeAITextExample/ViewModels/GenerateContentFromTemplateViewModel.swift
Outdated
Show resolved
Hide resolved
firebaseai/GenerativeAITextExample/Screens/GenerateContentFromTemplateScreen.swift
Show resolved
Hide resolved
firebaseai/GenerativeAITextExample/ViewModels/GenerateContentFromTemplateViewModel.swift
Outdated
Show resolved
Hide resolved
firebaseai/GenerativeAITextExample/ViewModels/GenerateContentFromTemplateViewModel.swift
Show resolved
Hide resolved
…romTemplateViewModel.swift Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
firebaseai/GenerativeAITextExample/Screens/GenerateContentFromTemplateScreen.swift
Outdated
Show resolved
Hide resolved
firebaseai/GenerativeAITextExample/ViewModels/GenerateContentFromTemplateViewModel.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Heard <[email protected]>
firebaseai/GenerativeAITextExample/ViewModels/GenerateContentFromTemplateViewModel.swift
Outdated
Show resolved
Hide resolved
…romTemplateViewModel.swift Co-authored-by: Andrew Heard <[email protected]>
Adds server template examples for Generate Content and image generation.