Skip to content

validator: add struct slice element name in namespace #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

validator: add struct slice element name in namespace #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions validator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,10 @@ OUTER:
switch kind {
case reflect.Slice, reflect.Array:

if cf.name == "" {
cf.name = typ.Elem().Name()
}

var i64 int64
reusableCF := &cField{}

Expand Down
19 changes: 19 additions & 0 deletions validator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,25 @@ func TestNameNamespace(t *testing.T) {
Equal(t, fe.StructField(), "String[1]")
Equal(t, fe.Namespace(), "Namespace.Inner1JSON.Inner2JSON.JSONString[1]")
Equal(t, fe.StructNamespace(), "Namespace.Inner1.Inner2.String[1]")

type SliceNamespace struct {
String string `validate:"required"`
}

sn := []SliceNamespace{{String: "a"}, {String: ""}}
errs = validate.Var(sn, "dive")
NotEqual(t, errs, nil)

ve = errs.(ValidationErrors)
Equal(t, len(ve), 1)
AssertError(t, errs, "SliceNamespace[1].String", "SliceNamespace[1].String", "String", "String", "required")

fe = getError(ve, "SliceNamespace[1].String", "SliceNamespace[1].String")
NotEqual(t, fe, nil)
Equal(t, fe.Field(), "String")
Equal(t, fe.StructField(), "String")
Equal(t, fe.Namespace(), "SliceNamespace[1].String")
Equal(t, fe.StructNamespace(), "SliceNamespace[1].String")
}

func TestAnonymous(t *testing.T) {
Expand Down