Skip to content

Fixed crashing when recieve notification on Android #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yokoboko wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixed crashing when recieve notification on Android #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
39c5227
Fixed crashing on android and adding 'priority' parameter
Apr 10, 2017
464dfdf
ANE
Apr 10, 2017
bd667a5
fixed get title text error
Apr 12, 2017
d4acfbb
ANE
Apr 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions android/src/com/freshplanet/nativeExtensions/CreateNotificationTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,16 +141,30 @@ protected void onPostExecute(Boolean downloadSuccess)
Extension.log("Couldn't create push notification: _context or _intent was null (CreateNotificationTask.onPostExecute)");
return;
}

//Bundle bundle = _intent.getExtras(); for (String key : bundle.keySet()) { Object value = bundle.get(key); Extension.log(String.format("Key:%s Value:%s Type:(%s)", key, value.toString(), value.getClass().getName())); }

// Notification texts
CharSequence contentTitle = _intent.getStringExtra("contentTitle");
CharSequence contentTitle = (_intent.getStringExtra("contentTitle") != null) ? _intent.getStringExtra("contentTitle") : "";
if (contentTitle.length() > 22)
{
contentTitle = contentTitle.subSequence(0, 20) + "...";
}
CharSequence contentText = _intent.getStringExtra("contentText");
CharSequence tickerText = _intent.getStringExtra("tickerText");
CharSequence contentText = (_intent.getStringExtra("contentText") != null) ? _intent.getStringExtra("contentText") : "";
CharSequence tickerText = (_intent.getStringExtra("tickerText") != null) ? _intent.getStringExtra("tickerText") : "";

// Set Priority
int priority = Notification.PRIORITY_DEFAULT;
String priotiryString = _intent.getStringExtra("priority");
if (priotiryString != null)
{
int priorityInt = Integer.parseInt(priotiryString);
if (priorityInt == 2) priority = Notification.PRIORITY_MAX;
else if (priorityInt == 1) priority = Notification.PRIORITY_HIGH;
else if (priorityInt == -1) priority = Notification.PRIORITY_LOW;
else if (priorityInt == -2) priority = Notification.PRIORITY_MIN;
}

String largeIconResourceId = _intent.getStringExtra("largeIconResourceId");

// Notification images
Expand Down Expand Up @@ -195,8 +209,9 @@ protected void onPostExecute(Boolean downloadSuccess)
.setSound(soundUri, AudioManager.STREAM_NOTIFICATION)
.setWhen(System.currentTimeMillis())
.setAutoCancel(true)
.setColor(0xFF2DA9F9)
.setPriority(priority)
.setContentIntent(contentIntent);
// .setColor(0xFF2DA9F9) CRASH!

Notification notification = builder.build();

Expand Down
Binary file modified bin/AirPushNotification.ane
View file
Open in desktop
Binary file not shown.