Fix the new Django admin user edit form's password change button (#129)

* Fix the new Django admin user edit form's password change button

At some point in the recent past
(https://code.djangoproject.com/ticket/34977), Django changed the user
edit form away from showing a link to the password change page, into a
button.  This relied on a call to `get_context()`, which this custom
password widget wasn't invoking.

* Wrap the hidden password in gettext

* Update the widget test to ensure the button is there

* Check for the admin password change view url in the test

This should work both for pre-5.0 and post-5.0 versions of Django.

Author: jbradberry

authtools/forms.py

@@ -31,22 +31,12 @@ class BetterReadOnlyPasswordHashWidget(ReadOnlyPasswordHashWidget):
     """
     A ReadOnlyPasswordHashWidget that has a less intimidating output.
     """
-    def render(self, name, value, attrs=None, renderer=None):
-        final_attrs = flatatt(self.build_attrs(attrs or {}))
 
-        if not value or not is_password_usable(value):
-            summary = gettext("No password set.")
-        else:
-            try:
-                identify_hasher(value)
-            except ValueError:
-                summary = gettext("Invalid password format or unknown"
-                                   " hashing algorithm.")
-            else:
-                summary = gettext('*************')
-
-        return format_html('<div{attrs}><strong>{summary}</strong></div>',
-                           attrs=final_attrs, summary=summary)
+    def get_context(self, name, value, attrs):
+        context = super().get_context(name, value, attrs)
+        if any(item.get('value') for item in context['summary']):
+            context['summary'] = [{'label': gettext('*************')}]
+        return context
 
 
 class UserChangeForm(DjangoUserChangeForm):

tests/tests/tests.py

@@ -2,6 +2,7 @@
 
 from unittest import skipIf, skipUnless
 
+import django
 from django.core import mail
 
 from django.test import TestCase
@@ -258,6 +259,15 @@ def test_better_readonly_password_widget(self):
 
         self.assertIn(_('*************'), form.as_table())
 
+        version = django.VERSION[0]
+
+        if version < 4:
+            self.assertIn('<a href="../password/">', form.as_table())
+        elif version < 5:
+            self.assertIn('<a href="../../{0}/password/">'.format(user.id), form.as_table())
+        else:
+            self.assertIn('<a class="button" href="../password/">', form.as_table())
+
 
 class UserAdminTest(TestCase):
     def test_generated_fieldsets(self):