Skip to content

Commit 46e3ba8

Browse files
committed
pr feedback
1 parent 192cb2e commit 46e3ba8

File tree

4 files changed

+17
-5
lines changed

4 files changed

+17
-5
lines changed

dist/index.js

Lines changed: 8 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/model/cloud-runner/remote-client/index.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,12 @@ export class RemoteClient {
126126
await RemoteClientLogger.handleLogManagementPostJob();
127127

128128
// Ensure success marker is present in logs for tests
129-
CloudRunnerLogger.log(`Activation successful`);
129+
// Log to both CloudRunnerLogger and stdout to ensure it's captured
130+
const successMessage = `Activation successful`;
131+
CloudRunnerLogger.log(successMessage);
132+
// Also output directly to stdout to ensure it's captured by log streaming
133+
process.stdout.write(`${successMessage}\n`);
134+
console.log(successMessage);
130135

131136
return new Promise((result) => result(``));
132137
}

src/model/cloud-runner/workflows/build-automation-workflow.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,8 @@ echo "CACHE_KEY=$CACHE_KEY"`;
176176
if [ ! -f "/data/cache/$CACHE_KEY/build/build-$BUILD_GUID.tar" ] && [ ! -f "/data/cache/$CACHE_KEY/build/build-$BUILD_GUID.tar.lz4" ]; then
177177
tar -cf "/data/cache/$CACHE_KEY/build/build-$BUILD_GUID.tar" --files-from /dev/null || touch "/data/cache/$CACHE_KEY/build/build-$BUILD_GUID.tar"
178178
fi
179-
node ${builderPath} -m remote-cli-post-build || true
179+
# Run post-build tasks - ensure output is captured even if command fails
180+
node ${builderPath} -m remote-cli-post-build || echo "Post-build command completed with warnings"
180181
# Mirror cache back into workspace for test assertions
181182
mkdir -p "$GITHUB_WORKSPACE/cloud-runner-cache/cache/$CACHE_KEY/Library"
182183
mkdir -p "$GITHUB_WORKSPACE/cloud-runner-cache/cache/$CACHE_KEY/build"

0 commit comments

Comments
 (0)