PR feedback

Author: frostebite

dist/index.js

@@ -63,7 +63,10 @@ class KubernetesPods {
 
       // Check if only PreStopHook failed but container succeeded
       const hasPreStopHookFailure = events.some((e) => e.reason === 'FailedPreStopHook');
+      const wasKilled = events.some((e) => e.reason === 'Killing');
 
+      // If container succeeded (exit code 0), PreStopHook failure is non-critical
+      // Also check if pod was killed but container might have succeeded
       if (containerSucceeded && containerExitCode === 0) {
         // Container succeeded - PreStopHook failure is non-critical
         if (hasPreStopHookFailure) {
@@ -79,6 +82,16 @@ class KubernetesPods {
         // Don't throw error - container succeeded, PreStopHook failure is non-critical
         return false; // Pod is not running, but we don't treat it as a failure
       }
+      
+      // If pod was killed and we have PreStopHook failure but no container status yet, wait a bit
+      // The container might have succeeded but status hasn't been updated yet
+      if (wasKilled && hasPreStopHookFailure && containerExitCode === undefined) {
+        CloudRunnerLogger.log(
+          `Pod ${podName} was killed with PreStopHook failure, but container status not yet available. This may be non-fatal if container succeeded.`,
+        );
+        // Still throw error for now, but with more context
+        // The task runner will retry and get the actual container status
+      }
 
       const errorMessage = `K8s pod failed\n${errorDetails.join('\n')}`;
       CloudRunnerLogger.log(errorMessage);

dist/index.js.map

@@ -79,9 +79,48 @@ export class Caching {
         return;
       }
 
-      await CloudRunnerSystem.Run(
-        `tar -cf ${cacheArtifactName}.tar${compressionSuffix} "${path.basename(sourceFolder)}"`,
-      );
+      // Check disk space before creating tar archive
+      try {
+        const diskCheckOutput = await CloudRunnerSystem.Run(`df -h . 2>/dev/null || df -h /data 2>/dev/null || true`);
+        CloudRunnerLogger.log(`Disk space before tar: ${diskCheckOutput}`);
+      } catch (error) {
+        // Ignore disk check errors
+      }
+
+      // Clean up any existing incomplete tar files
+      try {
+        await CloudRunnerSystem.Run(`rm -f ${cacheArtifactName}.tar${compressionSuffix} 2>/dev/null || true`);
+      } catch (error) {
+        // Ignore cleanup errors
+      }
+
+      try {
+        await CloudRunnerSystem.Run(
+          `tar -cf ${cacheArtifactName}.tar${compressionSuffix} "${path.basename(sourceFolder)}"`,
+        );
+      } catch (error: any) {
+        // Check if error is due to disk space
+        const errorMessage = error?.message || error?.toString() || '';
+        if (errorMessage.includes('No space left') || errorMessage.includes('Wrote only')) {
+          CloudRunnerLogger.log(`Disk space error detected. Attempting cleanup...`);
+          // Try to clean up old cache files
+          try {
+            const cacheParent = path.dirname(cacheFolder);
+            if (await fileExists(cacheParent)) {
+              // Find and remove old cache entries (keep only the most recent)
+              await CloudRunnerSystem.Run(
+                `find ${cacheParent} -name "*.tar*" -type f -mtime +1 -delete 2>/dev/null || true`,
+              );
+            }
+          } catch (cleanupError) {
+            CloudRunnerLogger.log(`Cleanup attempt failed: ${cleanupError}`);
+          }
+          throw new Error(
+            `Failed to create cache archive due to insufficient disk space. Error: ${errorMessage}. Please free up disk space and retry.`,
+          );
+        }
+        throw error;
+      }
       await CloudRunnerSystem.Run(`du ${cacheArtifactName}.tar${compressionSuffix}`);
       assert(await fileExists(`${cacheArtifactName}.tar${compressionSuffix}`), 'cache archive exists');
       assert(await fileExists(path.basename(sourceFolder)), 'source folder exists');