Skip to content

Commit f9ef711

Browse files
committed
PR feedback
1 parent ad9f2d3 commit f9ef711

File tree

1 file changed

+18
-8
lines changed

1 file changed

+18
-8
lines changed

.github/workflows/cloud-runner-integrity.yml

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,21 @@ jobs:
4141
run: |
4242
curl -s https://raw.githubusercontent.com/k3d-io/k3d/main/install.sh | bash
4343
k3d version | cat
44+
- name: Start LocalStack (S3)
45+
uses: localstack/[email protected]
46+
with:
47+
install-awslocal: true
48+
- name: Configure LocalStack for k3d access
49+
run: |
50+
# LocalStack should be accessible, but verify and configure if needed
51+
# Check if LocalStack is running and accessible
52+
curl -s http://localhost:4566/_localstack/health || echo "LocalStack health check failed"
53+
# Ensure LocalStack is listening on all interfaces (should be default)
54+
echo "LocalStack should be accessible at localhost:4566 and host.k3d.internal:4566"
55+
- name: Create S3 bucket for tests (host LocalStack)
56+
run: |
57+
awslocal s3 mb s3://$AWS_STACK_NAME || true
58+
awslocal s3 ls
4459
- name: Create k3s cluster (k3d)
4560
timeout-minutes: 5
4661
run: |
@@ -63,14 +78,9 @@ jobs:
6378
kubectl get storageclass
6479
# Show node resources
6580
kubectl describe nodes | grep -A 5 "Allocated resources" || true
66-
- name: Start LocalStack (S3)
67-
uses: localstack/[email protected]
68-
with:
69-
install-awslocal: true
70-
- name: Create S3 bucket for tests (host LocalStack)
71-
run: |
72-
awslocal s3 mb s3://$AWS_STACK_NAME || true
73-
awslocal s3 ls
81+
# Verify LocalStack is accessible from cluster via host.k3d.internal
82+
echo "Testing LocalStack connectivity from k3d cluster..."
83+
kubectl run test-localstack-connectivity --image=curlimages/curl --rm -i --restart=Never --timeout=10s -- curl -s --max-time 5 http://host.k3d.internal:4566/_localstack/health 2>&1 || echo "Note: LocalStack connectivity test - this is expected to work once LocalStack is fully ready"
7484
- uses: actions/setup-node@v4
7585
with:
7686
node-version: 20

0 commit comments

Comments
 (0)