adding suggestions

Author: nakul-py

packages/base/src/dialogs/symbology/colorRamps.ts

@@ -1,4 +1,4 @@
-import { IColorRampDefinition } from '@/src/types';
+import { ColorRampName, IColorRampDefinition } from '@/src/types';
 
 export const COLOR_RAMP_DEFINITIONS = {
   'rainbow-soft': { type: 'Cyclic' },
@@ -57,3 +57,10 @@ export const COLOR_RAMP_DEFINITIONS = {
   diff: { type: 'Divergent', criticalValue: 0.5 },
   tarn: { type: 'Divergent', criticalValue: 0.5 },
 } as const satisfies { [key: string]: IColorRampDefinition };
+
+export const COLOR_RAMP_DEFAULTS: Partial<Record<ColorRampName, number>> = {
+  hsv: 11,
+  picnic: 11,
+  'rainbow-soft': 11,
+  cubehelix: 16,
+};

packages/base/src/dialogs/symbology/components/color_ramp/ColorRampControls.tsx

@@ -21,13 +21,12 @@ import { IDict } from '@jupytergis/schema';
 import { Button } from '@jupyterlab/ui-components';
 import React, { useEffect, useState } from 'react';
 
-import { COLOR_RAMP_DEFINITIONS } from '@/src/dialogs/symbology/colorRamps';
-import { LoadingIcon } from '@/src/shared/components/loading';
 import {
+  COLOR_RAMP_DEFINITIONS,
   COLOR_RAMP_DEFAULTS,
-  ColorRampName,
-  ClassificationMode,
-} from '@/src/types';
+} from '@/src/dialogs/symbology/colorRamps';
+import { LoadingIcon } from '@/src/shared/components/loading';
+import { ColorRampName, ClassificationMode } from '@/src/types';
 import ColorRampSelector from './ColorRampSelector';
 import { ColorRampValueControls } from './ColorRampValueControls';
 import ModeSelectRow from './ModeSelectRow';
@@ -43,7 +42,6 @@ interface IColorRampControlsProps {
     setIsLoading: (isLoading: boolean) => void,
     minValue: number,
     maxValue: number,
-    criticalValue?: number,
   ) => void;
   showModeRow: boolean;
   showRampSelector: boolean;
@@ -143,13 +141,8 @@ const ColorRampControls: React.FC<IColorRampControlsProps> = ({
     // Typeguard: This should never happen
     return;
   }
-  const scaledCritical =
-    rampDef.type === 'Divergent' &&
-    minValue !== undefined &&
-    maxValue !== undefined
-      ? minValue + rampDef.criticalValue * (maxValue - minValue)
-      : undefined;
 
+  // update shared model symbology state from component state
   useEffect(() => {
     if (renderType === 'Heatmap') {
       return;
@@ -247,7 +240,6 @@ const ColorRampControls: React.FC<IColorRampControlsProps> = ({
               setIsLoading,
               minValue,
               maxValue,
-              scaledCritical,
             );
           }}
         >

packages/base/src/dialogs/symbology/hooks/useGetSingleBandInfo.ts

@@ -71,6 +71,7 @@ const useGetSingleBandInfo = (
 
       if (dataMin === undefined || dataMax === undefined) {
         // 2. Try smallest overview if available
+        // A consequence of this method is that we will almost never find the **true** minimum and maximum for the whole raster, as overviews are aggregate data, averaging groups of grid cells to calculate lower-resolution grid cells. However, calculating the minimum and maximum from the entire dataset may be prohibitively expensive on CPU and memory!
         const overviewCount = await tiff.getImageCount();
         const targetImage =
           overviewCount > 1 ? await tiff.getImage(overviewCount - 1) : image;

packages/base/src/types.ts

@@ -80,12 +80,6 @@ export interface IColorMap {
 
 export type ColorRampName = keyof typeof COLOR_RAMP_DEFINITIONS;
 
-export const COLOR_RAMP_DEFAULTS: Partial<Record<ColorRampName, number>> = {
-  hsv: 11,
-  picnic: 11,
-  'rainbow-soft': 11,
-  cubehelix: 16,
-};
 const classificationModes = [
   'quantile',
   'equal interval',