now saving them for Graduated

Author: nakul-py

packages/base/src/dialogs/symbology/components/color_ramp/ColorRampControls.tsx

@@ -144,37 +144,6 @@ const ColorRampControls: React.FC<IColorRampControlsProps> = ({
     return;
   }
 
-  // update shared model symbology state from component state
-  useEffect(() => {
-    if (renderType === 'Heatmap') {
-      return;
-    }
-
-    if (!layerParams.symbologyState) {
-      layerParams.symbologyState = {};
-    }
-    layerParams.symbologyState = {
-      ...layerParams.symbologyState,
-      dataMin,
-      dataMax,
-      min: minValue,
-      max: maxValue,
-      colorRamp: selectedRamp,
-      reverse: reverseRamp,
-      nClasses: numberOfShades,
-      mode: selectedMode,
-    };
-  }, [
-    minValue,
-    maxValue,
-    selectedRamp,
-    reverseRamp,
-    selectedMode,
-    numberOfShades,
-    dataMin,
-    dataMax,
-  ]);
-
   return (
     <div className="jp-gis-color-ramp-container">
       {showRampSelector && (

packages/base/src/dialogs/symbology/components/color_ramp/ColorRampValueControls.tsx

@@ -1,7 +1,7 @@
 import { Button } from '@jupyterlab/ui-components';
 import React from 'react';
 
-import { IColorRampDefinition } from '@/src/types';
+import { IColorRampDefinition, ClassificationMode } from '@/src/types';
 
 export interface IColorRampValueControlsProps {
   selectedMin: number | undefined;
@@ -16,7 +16,7 @@ export interface IColorRampValueControlsProps {
     | 'Singleband Pseudocolor';
   dataMin?: number;
   dataMax?: number;
-  selectedMode: string; // TODO: should be ClssificationMode (https://github.com/geojupyter/jupytergis/pull/937)
+  selectedMode: ClassificationMode;
 }
 export const ColorRampValueControls: React.FC<
   IColorRampValueControlsProps

packages/base/src/dialogs/symbology/vector_layer/types/Graduated.tsx

@@ -208,6 +208,8 @@ const Graduated: React.FC<ISymbologyTabbedDialogWithAttributesProps> = ({
       mode: colorRampOptionsRef.current?.selectedMode,
       min: colorRampOptionsRef.current?.minValue,
       max: colorRampOptionsRef.current?.maxValue,
+      dataMin: colorRampOptionsRef.current?.dataMin,
+      dataMax: colorRampOptionsRef.current?.dataMax,
     };
 
     if (layer.type === 'HeatmapLayer') {
@@ -236,6 +238,8 @@ const Graduated: React.FC<ISymbologyTabbedDialogWithAttributesProps> = ({
       minValue,
       maxValue,
       criticalValue,
+      dataMin,
+      dataMax,
     });
 
     let stops: number[];