Skip to content

Commit 2589bef

Browse files
JesserajeshmauryasdeLimits0xrajeshmauryasdekatsugeneration
authored
Update V10 release branch to 10.1 (#5655)
* Add support for Firebolt Database (#5606) * Fixes issue #5622 (#5623) * Update Readme to reflect Firebolt data source (#5649) * Speed up BigQuery schema fetching (#5632) New method improves schema fetching by as much as 98% on larger schemas * Merge pull request from GHSA-vhc7-w7r8-8m34 * WIP: break the flask_oauthlib behavior * Refactor google-oauth to use cryptographic state. * Clean up comments * Fix: tests didn't pass because of the scope issues. Moved outside the create_blueprint method because this does not depend on the Authlib object. * Apply Arik's fixes. Tests pass. * Merge pull request from GHSA-g8xr-f424-h2rv * Merge pull request from GHSA-fcpv-hgq6-87h7 * Update changelog to incorporate security fixes and #5632 & #5606 (#5654) * Update changelog to incorporate security fixes and #5632 & #5606 * Added reference to sqlite fix * Bump to V10.1 * Missed package-lock.json on the first pass * Add a REDASH_COOKIE_SECRET for circleci * Revert "Add a REDASH_COOKIE_SECRET for circleci" This reverts commit 4576636. Moves config to the correct compose files * Move advocate to core requirements.txt file [debugging circleci failures] Co-authored-by: rajeshSigmoid <[email protected]> Co-authored-by: Aratrik Pal <[email protected]> Co-authored-by: rajeshmauryasde <[email protected]> Co-authored-by: Katsuya Shimabukuro <[email protected]>
1 parent 1c5ceec commit 2589bef

File tree

23 files changed

+286
-163
lines changed

23 files changed

+286
-163
lines changed

.circleci/docker-compose.circle.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ services:
1313
REDASH_LOG_LEVEL: "INFO"
1414
REDASH_REDIS_URL: "redis://redis:6379/0"
1515
REDASH_DATABASE_URL: "postgresql://postgres@postgres/postgres"
16+
REDASH_COOKIE_SECRET: "2H9gNG9obnAQ9qnR9BDTQUph6CbXKCzF"
1617
redis:
1718
image: redis:3.0-alpine
1819
restart: unless-stopped

.circleci/docker-compose.cypress.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ x-redash-environment: &redash-environment
1212
REDASH_DATABASE_URL: "postgresql://postgres@postgres/postgres"
1313
REDASH_RATELIMIT_ENABLED: "false"
1414
REDASH_ENFORCE_CSRF: "true"
15+
REDASH_COOKIE_SECRET: "2H9gNG9obnAQ9qnR9BDTQUph6CbXKCzF"
1516
services:
1617
server:
1718
<<: *redash-service

CHANGELOG.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,19 @@
11
# Change Log
22

3+
## V10.1.0 - 2021-11-23
4+
5+
This release includes patches for three security vulnerabilities:
6+
7+
- Insecure default configuration affects installations where REDASH_COOKIE_SECRET is not set explicitly (CVE-2021-41192)
8+
- SSRF vulnerability affects installations that enabled URL-loading data sources (CVE-2021-43780)
9+
- Incorrect usage of state parameter in OAuth client code affects installations where Google Login is enabled (CVE-2021-43777)
10+
11+
And a couple features that didn't merge in time for 10.0.0
12+
13+
- Big Query: Speed up schema loading (#5632)
14+
- Add support for Firebolt data source (#5606)
15+
- Fix: Loading schema for Sqlite DB with "Order" column name fails (#5623)
16+
317
## v10.0.0 - 2021-10-01
418

519
A few changes were merged during the V10 beta period.

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ Redash supports more than 35 SQL and NoSQL [data sources](https://redash.io/help
4343
- DB2 by IBM
4444
- Druid
4545
- Elasticsearch
46+
- Firebolt
4647
- Google Analytics
4748
- Google BigQuery
4849
- Google Spreadsheets
12.4 KB
Loading

docker-compose.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ x-redash-service: &redash-service
88
skip_frontend_build: "true"
99
volumes:
1010
- .:/app
11+
env_file:
12+
- .env
1113
x-redash-environment: &redash-environment
1214
REDASH_LOG_LEVEL: "INFO"
1315
REDASH_REDIS_URL: "redis://redis:6379/0"
@@ -16,6 +18,7 @@ x-redash-environment: &redash-environment
1618
REDASH_MAIL_DEFAULT_SENDER: "[email protected]"
1719
REDASH_MAIL_SERVER: "email"
1820
REDASH_ENFORCE_CSRF: "true"
21+
# Set secret keys in the .env file
1922
services:
2023
server:
2124
<<: *redash-service

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "redash-client",
3-
"version": "10.0.0",
3+
"version": "10.1.0",
44
"description": "The frontend part of Redash.",
55
"main": "index.js",
66
"scripts": {

redash/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
from .query_runner import import_query_runners
1616
from .destinations import import_destinations
1717

18-
__version__ = "10.0.0"
18+
__version__ = "10.1.0"
1919

2020

2121
if os.environ.get("REMOTE_DEBUG"):

redash/authentication/__init__.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -243,12 +243,13 @@ def logout_and_redirect_to_index():
243243

244244
def init_app(app):
245245
from redash.authentication import (
246-
google_oauth,
247246
saml_auth,
248247
remote_user_auth,
249248
ldap_auth,
250249
)
251250

251+
from redash.authentication.google_oauth import create_google_oauth_blueprint
252+
252253
login_manager.init_app(app)
253254
login_manager.anonymous_user = models.AnonymousUser
254255
login_manager.REMEMBER_COOKIE_DURATION = settings.REMEMBER_COOKIE_DURATION
@@ -259,8 +260,9 @@ def extend_session():
259260
app.permanent_session_lifetime = timedelta(seconds=settings.SESSION_EXPIRY_TIME)
260261

261262
from redash.security import csrf
262-
for auth in [google_oauth, saml_auth, remote_user_auth, ldap_auth]:
263-
blueprint = auth.blueprint
263+
264+
# Authlib's flask oauth client requires a Flask app to initialize
265+
for blueprint in [create_google_oauth_blueprint(app), saml_auth.blueprint, remote_user_auth.blueprint, ldap_auth.blueprint, ]:
264266
csrf.exempt(blueprint)
265267
app.register_blueprint(blueprint)
266268

0 commit comments

Comments
 (0)