Merge pull request #24 from getsentry/iw/node-20

Update Node version and dependencies

Author: IanWoodard

.eslintrc.json

@@ -35,7 +35,6 @@
       "@typescript-eslint/prefer-function-type": "warn",
       "@typescript-eslint/prefer-includes": "error",
       "@typescript-eslint/prefer-string-starts-ends-with": "error",
-      "@typescript-eslint/promise-function-async": "error",
       "@typescript-eslint/require-array-sort-compare": "error",
       "@typescript-eslint/restrict-plus-operands": "error",
       "semi": "off",

.github/workflows/test.yml

@@ -11,10 +11,11 @@ jobs:
   test:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v1
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
-          node-version: 12
+          node-version: '>=20'
       - run: yarn install
+      - run: yarn build
       - run: yarn lint
       - run: yarn test

action.yml

@@ -27,5 +27,5 @@ outputs:
   pullRequest:
     description: Stringified pull request object
 runs:
-  using: 'node16'
+  using: 'node20'
   main: 'dist/index.js'

package.json

@@ -4,6 +4,13 @@
   "private": true,
   "description": "This checks current PR body for a dependent PR",
   "main": "lib/index.js",
+  "engines": {
+    "node": ">=20"
+  },
+  "volta": {
+    "node": "20.3.0",
+    "yarn": "1.22.17"
+  },
   "scripts": {
     "build": "yarn tsc",
     "format": "yarn prettier --write **/*.ts",
@@ -36,27 +43,27 @@
     ]
   },
   "dependencies": {
-    "@actions/core": "^1.2.5",
-    "@actions/github": "^4.0.0",
+    "@actions/core": "^1.10.0",
+    "@actions/github": "^6.0.0",
     "github-app-token": "^1.0.3"
   },
   "devDependencies": {
-    "@types/jest": "^26.0.10",
-    "@types/node": "^14.6.1",
-    "@typescript-eslint/eslint-plugin": "^3.10.1",
-    "@typescript-eslint/parser": "^3.10.1",
-    "@vercel/ncc": "^0.24.0",
-    "eslint": "^7.7.0",
-    "eslint-config-sentry": "^1.43.0",
-    "eslint-plugin-jest": "^23.20.0",
-    "eslint-plugin-prettier": "^3.1.4",
+    "@types/jest": "^29.5.12",
+    "@types/node": "^20.11.28",
+    "@typescript-eslint/eslint-plugin": "^7.2.0",
+    "@typescript-eslint/parser": "^7.2.0",
+    "@vercel/ncc": "^0.38.1",
+    "eslint": "^8.57.0",
+    "eslint-config-sentry": "^2.5.0",
+    "eslint-plugin-jest": "^27.9.0",
+    "eslint-plugin-prettier": "^5.1.3",
     "husky": "^4.2.5",
-    "jest": "^26.4.2",
-    "jest-circus": "^26.4.2",
-    "js-yaml": "^3.13.1",
+    "jest": "^29.7.0",
+    "jest-circus": "^29.7.0",
+    "js-yaml": "^4.1.0",
     "lint-staged": "^10.2.13",
-    "prettier": "^2.1.1",
-    "ts-jest": "^26.3.0",
-    "typescript": "^4.0.2"
+    "prettier": "^3.2.5",
+    "ts-jest": "^29.1.2",
+    "typescript": "^5.4.2"
   }
 }

src/main.ts

@@ -24,7 +24,7 @@ async function run(): Promise<void> {
 
     // We want to fetch the pull request on every run, if we use the workflow event
     // payload, the PR body text can be stale e.g. if you re-run a workflow
-    const sourcePullRequest = await octokit.pulls.get({
+    const sourcePullRequest = await octokit.rest.pulls.get({
       owner,
       repo,
       // @ts-ignore (typing is wrong for this)
@@ -52,7 +52,7 @@ async function run(): Promise<void> {
 
     const [, targetOwner, targetRepo, targetPullRequestNumber] = matches;
 
-    const pullRequest = await octokit.pulls.get({
+    const pullRequest = await octokit.rest.pulls.get({
       owner: targetOwner,
       repo: targetRepo,
       // @ts-ignore (typing is wrong for this)
@@ -65,7 +65,9 @@ async function run(): Promise<void> {
     core.setOutput('number', pullRequest.data.number);
     core.setOutput('pullRequest', JSON.stringify(pullRequest.data));
   } catch (error) {
-    core.setFailed(error.message);
+    if (error instanceof Error) {
+      core.error(error.message);
+    }
   }
 }
 

src/wait.ts

@@ -1,4 +1,4 @@
-export async function wait(milliseconds: number): Promise<string> {
+export function wait(milliseconds: number): Promise<string> {
   return new Promise(resolve => {
     if (isNaN(milliseconds)) {
       throw new Error('milliseconds not a number');