Skip to content

Conversation

@spalmurray
Copy link
Contributor

@spalmurray spalmurray commented Nov 6, 2025

WIP. Adds a sync mechanism for slack participants on Incidents. Details:

  • Sync happens on request to UI/Service API(todo) view.
  • Throttled to at most one update per 5 minutes.
  • If slack users do not have firetower accounts, will create one and sync it to IAP later on first login.
  • Sync ignores bot users
  • Adds a manual django admin action to sync also.
  • Adds an endpoint to force a slack sync (will be triggered by refresh button in UI).

todos:

  • rebase onto Service API and ensure urls and views are set up nicely.
  • rebase onto ruff/mypy and add types

@spalmurray spalmurray force-pushed the spalmurray/slack-participants-sync branch from f1b7ae8 to 70bb8d1 Compare November 6, 2025 22:16
@spalmurray spalmurray force-pushed the spalmurray/slack-participants-sync branch from 76d07a7 to f6d9e69 Compare November 13, 2025 18:52
@spalmurray spalmurray changed the title (WIP)feat: Add slack participants sync mechanism feat: Add slack participants sync mechanism Nov 13, 2025
@spalmurray spalmurray marked this pull request as ready for review November 13, 2025 19:06
@keeakita keeakita self-requested a review November 13, 2025 21:06
Copy link
Member

@keeakita keeakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a fine initial approach, but I think ideally I'd rather have Slack user information be its own model that is then JOINed to IAP user info, rather than updating the email field. It seems conceptually easier to work with as we won't have two types of user crammed into one data model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants