Skip to content

Commit 54c0b9b

Browse files
k-fishjjbayer
andauthored
ref(tracemetrics): Add more logging for internal reason (#5359)
Co-authored-by: Joris Bayer <[email protected]>
1 parent e96e4b0 commit 54c0b9b

File tree

1 file changed

+7
-5
lines changed
  • relay-server/src/processing/trace_metrics

1 file changed

+7
-5
lines changed

relay-server/src/processing/trace_metrics/mod.rs

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,7 @@ impl crate::managed::OutcomeError for Error {
6161
Self::Filtered(f) => Some(Outcome::Filtered(f.clone())),
6262
Self::DuplicateContainer => Some(Outcome::Invalid(DiscardReason::DuplicateItem)),
6363
Self::ProcessingFailed(_) => {
64-
relay_log::error!(
65-
error = &self as &dyn std::error::Error,
66-
"internal error: trace metric processing failed"
67-
);
64+
relay_log::error!("internal error: trace metric processing failed");
6865
Some(Outcome::Invalid(DiscardReason::Internal))
6966
}
7067
Self::PiiConfig(_) => Some(Outcome::Invalid(DiscardReason::ProjectStatePii)),
@@ -151,7 +148,12 @@ impl Forward for TraceMetricOutput {
151148
self.0.try_map(|metrics, _| {
152149
metrics
153150
.serialize_envelope()
154-
.map_err(drop)
151+
.map_err(|error| {
152+
relay_log::error!(
153+
error = %error,
154+
"internal error: failed to serialize trace metrics envelope"
155+
);
156+
})
155157
.with_outcome(Outcome::Invalid(DiscardReason::Internal))
156158
})
157159
}

0 commit comments

Comments
 (0)