Skip to content

Commit 3066381

Browse files
authored
Revert "Add additional path to check for ios dsyms (#342)"
This reverts commit 8da8e1d.
1 parent 8da8e1d commit 3066381

File tree

3 files changed

+3
-24
lines changed

3 files changed

+3
-24
lines changed

CHANGELOG.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
# Changelog
22

3-
## Unreleased
4-
5-
### Fixes
6-
7-
- Add additional path to check for iOS debug symbols ([#342](https://github.com/getsentry/sentry-dart-plugin/pull/342))
8-
93
## 3.1.0
104

115
### Features

lib/sentry_dart_plugin.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ class SentryDartPlugin {
102102

103103
Stream<String> _enumerateDebugSymbolPaths(FileSystem fs) async* {
104104
final buildDir = _configuration.buildFilesFolder;
105-
final projectRoot = fs.currentDirectory.path;
106105

107106
// Android (apk, appbundle)
108107
yield '$buildDir/app/outputs';
@@ -143,9 +142,6 @@ class SentryDartPlugin {
143142

144143
// iOS (ios-framework)
145144
yield '$buildDir/ios/framework/Release';
146-
147-
// iOS in Fastlane
148-
yield '$projectRoot/ios/build';
149145
}
150146

151147
Future<Set<String>> _enumerateSymbolFiles() async {

test/plugin_test.dart

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -406,7 +406,6 @@ void main() {
406406
const version = '1.0.0';
407407
final config = 'upload_debug_symbols: true';
408408

409-
// Default output directories in build/
410409
final outputDirectories = [
411410
'app/outputs',
412411
'app/intermediates',
@@ -421,32 +420,22 @@ void main() {
421420
'ios/Release-iphoneos',
422421
'ios/Release-anyrandomflavor-iphoneos',
423422
'ios/archive',
424-
'ios/framework/Release',
423+
'ios/framework/Release'
425424
];
426-
// Alternative output directories from 'root'
427-
final alternativeOutputDirectories = ['ios/build'];
428425
for (final dir in outputDirectories) {
429426
fs
430427
.directory(buildDir)
431428
.childDirectory(dir)
432429
.createSync(recursive: true);
433430
}
434-
for (final dir in alternativeOutputDirectories) {
435-
fs
436-
.directory(buildDir)
437-
.childDirectory(dir)
438-
.createSync(recursive: true);
439-
}
440431

441432
final commandLog = await runWith(version, config);
442433

443434
for (final dir in outputDirectories) {
444435
expect(
445436
commandLog,
446-
contains(anyOf([
447-
'$cli $commonArgs debug-files upload $orgAndProject $buildDir/$dir',
448-
'$cli $commonArgs debug-files upload $orgAndProject $dir'
449-
])));
437+
contains(
438+
'$cli $commonArgs debug-files upload $orgAndProject $buildDir/$dir'));
450439
}
451440
});
452441
});

0 commit comments

Comments
 (0)