From 093c086598eb5206160e5dc8868216919129a9d5 Mon Sep 17 00:00:00 2001 From: Giancarlo Buenaflor Date: Tue, 15 Jul 2025 13:59:15 +0200 Subject: [PATCH 1/4] Add additional path to check for ios dsyms --- lib/sentry_dart_plugin.dart | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/sentry_dart_plugin.dart b/lib/sentry_dart_plugin.dart index a69463d..abbbe21 100644 --- a/lib/sentry_dart_plugin.dart +++ b/lib/sentry_dart_plugin.dart @@ -102,6 +102,7 @@ class SentryDartPlugin { Stream _enumerateDebugSymbolPaths(FileSystem fs) async* { final buildDir = _configuration.buildFilesFolder; + final String projectRoot = fs.currentDirectory.path; // Android (apk, appbundle) yield '$buildDir/app/outputs'; @@ -142,6 +143,9 @@ class SentryDartPlugin { // iOS (ios-framework) yield '$buildDir/ios/framework/Release'; + + // iOS in Fastlane + yield '$projectRoot/ios/build'; } Future> _enumerateSymbolFiles() async { From 2dce54e437ad28f31dda074dde97e309bc917536 Mon Sep 17 00:00:00 2001 From: Giancarlo Buenaflor Date: Tue, 15 Jul 2025 15:00:48 +0200 Subject: [PATCH 2/4] Add test --- test/plugin_test.dart | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/test/plugin_test.dart b/test/plugin_test.dart index b2feb57..8622de2 100644 --- a/test/plugin_test.dart +++ b/test/plugin_test.dart @@ -406,6 +406,7 @@ void main() { const version = '1.0.0'; final config = 'upload_debug_symbols: true'; + // Default output directories in build/ final outputDirectories = [ 'app/outputs', 'app/intermediates', @@ -420,22 +421,32 @@ void main() { 'ios/Release-iphoneos', 'ios/Release-anyrandomflavor-iphoneos', 'ios/archive', - 'ios/framework/Release' + 'ios/framework/Release', ]; + // Alternative output directories from 'root' + final alternativeOutputDirectories = ['ios/build']; for (final dir in outputDirectories) { fs .directory(buildDir) .childDirectory(dir) .createSync(recursive: true); } + for (final dir in alternativeOutputDirectories) { + fs + .directory(buildDir) + .childDirectory(dir) + .createSync(recursive: true); + } final commandLog = await runWith(version, config); for (final dir in outputDirectories) { expect( commandLog, - contains( - '$cli $commonArgs debug-files upload $orgAndProject $buildDir/$dir')); + contains(anyOf([ + '$cli $commonArgs debug-files upload $orgAndProject $buildDir/$dir', + '$cli $commonArgs debug-files upload $orgAndProject $dir' + ]))); } }); }); From df6c67c82e65b9418bf568338348dddf4b959b5a Mon Sep 17 00:00:00 2001 From: Giancarlo Buenaflor Date: Tue, 15 Jul 2025 15:01:44 +0200 Subject: [PATCH 3/4] Update --- CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b95ce22..550ac2f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # Changelog +## Unreleased + +### Fixes + +- Add additional path to check for iOS debug symbols ([#342](https://github.com/getsentry/sentry-dart-plugin/pull/342)) + ## 3.1.0 ### Features From 538dea8a631029e84b6a67cf416b8788c3838910 Mon Sep 17 00:00:00 2001 From: Giancarlo Buenaflor Date: Tue, 15 Jul 2025 15:06:34 +0200 Subject: [PATCH 4/4] Update sentry_dart_plugin.dart --- lib/sentry_dart_plugin.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sentry_dart_plugin.dart b/lib/sentry_dart_plugin.dart index abbbe21..537dd1a 100644 --- a/lib/sentry_dart_plugin.dart +++ b/lib/sentry_dart_plugin.dart @@ -102,7 +102,7 @@ class SentryDartPlugin { Stream _enumerateDebugSymbolPaths(FileSystem fs) async* { final buildDir = _configuration.buildFilesFolder; - final String projectRoot = fs.currentDirectory.path; + final projectRoot = fs.currentDirectory.path; // Android (apk, appbundle) yield '$buildDir/app/outputs';