PHP Monolog logs #14781
Open
PHP Monolog logs #14781
+86
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 313.62kB (-1.37%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
App Routes Affected:
|
cleptric
force-pushed
the
php-monolog
branch
from
16c4d50 to
d65ed14
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| $logger = new Logger('sentry_logs'); | ||
| $logger->pushHandler(new \Sentry\Monolog\LogsHandler( | ||
| LogLevel::info(), // Minimum level to send logs | ||
| )); |
There was a problem hiding this comment.
Bug: Sentry Monolog LogsHandler: Parameter Mismatch
The LogsHandler is instantiated with incorrect parameters. It uses LogLevel::info() from Sentry\Logs\LogLevel (called as a method with parentheses) instead of Monolog\Level::Info, and it's missing the hub parameter with named arguments. Other Sentry Monolog handlers in the same file (BreadcrumbHandler and Handler) consistently use named parameters with hub: \Sentry\SentrySdk::getCurrentHub() and level: Level::Info, which is the correct pattern.
Contributor
There was a problem hiding this comment.
LogsHandler uses (LogLevel, bool) in the constructor. This comment would be correct for BreadcrumbHandler which uses a different signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1893
closes PHP-22