feat(caching) Release registry caching #15339
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bundle ReportChanges will decrease total bundle size by 232.61kB (-0.99%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
Files in
|
sergical
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- Strip ISO timestamps (2025-10-29T16:22:19) before hashing - Normalize Next.js asset hashes in paths (/_next/static/css/abc123...) - Bump CACHE_VERSION to 4 since cache key format changed - This should fix the 99.99% cache miss rate
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- Reverted timestamp/asset hash normalization (not verified) - Instead: save first 2000 chars of HTML to debug file - This lets us diff between builds to see what's ACTUALLY changing - Will investigate properly before applying fixes
- Log existing v4 cache files for comparison - Log HTML in 800-char chunks to avoid truncation - This way we can compare build logs to see what's changing
- Saves each cache miss HTML to .next/cache/debug-html-samples/ - Filenames include timestamp for comparison between builds - Only runs locally (skips in CI) - Can diff files to see what's actually changing
BYK
approved these changes
Nov 7, 2025
Member
BYK
left a comment
BYK
left a comment
There was a problem hiding this comment.
Did not check src/mdex.ts but if this works things look pretty good overall. Let's ship and fix things later if there's anything to fix.
Made some suggestions for better perf but they are not blockers.
| const cacheHits = success - cacheMisses.length; | ||
| console.log( | ||
| `📈 Worker[${id}]: Cache stats: ${cacheHits} hits, ${cacheMisses.length} misses (${((cacheMisses.length / success) * 100).toFixed(1)}% miss rate)` | ||
| ); |
There was a problem hiding this comment.
Bug: Division by zero breaks cache miss rate.
Division by zero occurs when calculating cache miss percentage if all tasks fail. When success equals zero (all tasks failed), the expression cacheMisses.length / success produces NaN, resulting in the log message displaying "NaN% miss rate" instead of handling the edge case gracefully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Problem
Solution
Impact
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES