-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(preprod): Add build distribution docs #15463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Fixes EME-453
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bundle ReportChanges will increase total bundle size by 19.21kB (0.08%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
Files in
App Routes Affected:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
|
|
||
| ### Build Configuration | ||
|
|
||
| <Include name="size-analysis/upload-metadata" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Clean Up Android Build Configuration Duplication
The Build Configuration section duplicates the same size-analysis/upload-metadata include that appears in the Upload Metadata section above. Based on the iOS documentation structure and the existing Android size-analysis page, this should be size-analysis/build-configuration-android instead.
…ponents - Create GradleUploadInstructions component to consolidate shared code - Create GradleFeatureConfig component for Gradle configuration snippets - Update build-distribution and size-analysis to use new components - Add missing android-metadata.png image to both includes and public directories - Register new components in mdxComponents.ts This reduces duplication across documentation files and makes it easier to maintain Gradle-related instructions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
5bfc323 to
81f8bf5
Compare
| src="/platforms/android/build-distribution/images/android-metadata.png" | ||
| alt="Upload metadata" | ||
| style={{maxWidth: '400px'}} | ||
| /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Feature Context Mismatch in Image Paths
The image source path is hardcoded to /platforms/android/build-distribution/images/android-metadata.png but this component is used for both build distribution and size analysis features. When used in size analysis documentation via <GradleUploadInstructions feature="sizeAnalysis" />, it incorrectly references the build-distribution image path instead of the size-analysis image path.
Use codeToJsx with CodeTabs for proper syntax highlighting across all Gradle configuration examples. This includes Kotlin/Groovy configuration blocks and aab/apk build command examples. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Remove unused gradle-config files and duplicate android-metadata.png from includes directory. The android-metadata.png in public/ is the one being used. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
| - [iOS](/platforms/apple/guides/ios/build-distribution/) | ||
| - [Android](/platforms/android/build-distribution/) | ||
|
|
||
| ### Upload Metadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this section is redundant since it also appears in the sections for each platform.
|
|
||
| ### CI Integration | ||
|
|
||
| Integrate Build Distribution into your CI pipeline to automatically distribute builds to your teams. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to mention anything else?
There's no difference if a build is uploaded from a local build vs a CI build for the purposes of size analysis. There isn't any github integration either.
|
|
||
| // If a new language should be supported, add it here and register it in refractor above | ||
| export const SUPPORTED_LANGUAGES = ['bash', 'json', 'typescript']; | ||
| export const SUPPORTED_LANGUAGES = ['bash', 'groovy', 'json', 'kotlin', 'typescript']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, i think this was the fix for the language syntax highlighting inside codeToJsx 😓
|
|
||
| <Include name="size-analysis/build-configuration-ios" /> | ||
|
|
||
| ## Distribution Management |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is something missing here? It seems like there's no content for 'Distribution Management' under this header.
|
|
||
| ## What's Next? | ||
|
|
||
| We strongly recommend integrating Build Distribution into your CI pipeline for automated distribution workflows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may be misinterpreting, but is this recommending what we've already done on this page as the 'next step'? Is there a recommended next step that can link to another place in docs?
coolguyzone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big lift, thanks for adding all this! I added a couple of questions for clarification, but overall looks good.
DESCRIBE YOUR PR
This adds docs for mobile Build Distribution which is going into EA.
Build Distribution is very similar to Size Analysis so we mostly reused
or shared the existing content. We'll add more Build Distribution
specific content as they land going towards GA.
Fixes EME-453
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: