Skip to content

Conversation

@chromy
Copy link
Contributor

@chromy chromy commented Nov 11, 2025

DESCRIBE YOUR PR

This adds docs for mobile Build Distribution which is going into EA.
Build Distribution is very similar to Size Analysis so we mostly reused
or shared the existing content. We'll add more Build Distribution
specific content as they land going towards GA.

Fixes EME-453

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Nov 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
develop-docs Ready Ready Preview Comment Nov 12, 2025 4:56pm
sentry-docs Ready Ready Preview Comment Nov 12, 2025 4:56pm

@linear
Copy link

linear bot commented Nov 11, 2025

@codeowner-assignment codeowner-assignment bot requested a review from a team November 11, 2025 14:00
@codecov
Copy link

codecov bot commented Nov 11, 2025

Bundle Report

Changes will increase total bundle size by 19.21kB (0.08%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.17MB 3.98kB (0.04%) ⬆️
sentry-docs-server-cjs 12.63MB 15.23kB (0.12%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.74MB -0.0%
../instrumentation.js -3 bytes 1.07MB -0.0%
7161.js (New) 1.05MB 1.05MB 100.0% 🚀
9523.js -3 bytes 1.04MB -0.0%
../app/[[...path]]/page.js.nft.json 1.36kB 769.24kB 0.18%
../app/platform-redirect/page.js.nft.json 1.36kB 769.15kB 0.18%
../app/sitemap.xml/route.js.nft.json 1.36kB 766.38kB 0.18%
../app/[[...path]]/page.js 11.02kB 630.88kB 1.78%
1614.js (Deleted) -1.05MB 0 bytes -100.0% 🗑️

Files in ../app/[[...path]]/page.js:

  • ./src/components/gradleUploadInstructions.tsx → Total Size: 16.59kB

  • ./src/components/gradleFeatureConfig.tsx → Total Size: 1.46kB

  • ./src/mdxComponents.ts → Total Size: 4.55kB

App Routes Affected:

App Route Size Change Total Size Change (%)
/[[...path]] 11.02kB 3.38MB 0.33%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/chunks/2195-*.js (New) 288.74kB 288.74kB 100.0% 🚀
static/chunks/app/[[...path]]/page-*.js 165 bytes 95.99kB 0.17%
server/middleware-*.js -6.46kB 1.0kB -86.59%
server/middleware-*.js 6.46kB 7.46kB 645.5% ⚠️
static/6IDHJ_7jW2JABVCMVfqPC/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/6IDHJ_7jW2JABVCMVfqPC/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/chunks/8423-*.js (Deleted) -284.92kB 0 bytes -100.0% 🗑️
static/ODVmn0licrlQhojpguJ90/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/ODVmn0licrlQhojpguJ90/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️


### Build Configuration

<Include name="size-analysis/upload-metadata" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Clean Up Android Build Configuration Duplication

The Build Configuration section duplicates the same size-analysis/upload-metadata include that appears in the Upload Metadata section above. Based on the iOS documentation structure and the existing Android size-analysis page, this should be size-analysis/build-configuration-android instead.

Fix in Cursor Fix in Web

…ponents

- Create GradleUploadInstructions component to consolidate shared code
- Create GradleFeatureConfig component for Gradle configuration snippets
- Update build-distribution and size-analysis to use new components
- Add missing android-metadata.png image to both includes and public directories
- Register new components in mdxComponents.ts

This reduces duplication across documentation files and makes it easier to maintain Gradle-related instructions.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@runningcode runningcode force-pushed the chromy/2025-11-11-add-distro-docs branch from 5bfc323 to 81f8bf5 Compare November 12, 2025 14:12
src="/platforms/android/build-distribution/images/android-metadata.png"
alt="Upload metadata"
style={{maxWidth: '400px'}}
/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Feature Context Mismatch in Image Paths

The image source path is hardcoded to /platforms/android/build-distribution/images/android-metadata.png but this component is used for both build distribution and size analysis features. When used in size analysis documentation via <GradleUploadInstructions feature="sizeAnalysis" />, it incorrectly references the build-distribution image path instead of the size-analysis image path.

Fix in Cursor Fix in Web

runningcode and others added 3 commits November 12, 2025 17:34
Use codeToJsx with CodeTabs for proper syntax highlighting across all
Gradle configuration examples. This includes Kotlin/Groovy configuration
blocks and aab/apk build command examples.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Remove unused gradle-config files and duplicate android-metadata.png
from includes directory. The android-metadata.png in public/ is the
one being used.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
- [iOS](/platforms/apple/guides/ios/build-distribution/)
- [Android](/platforms/android/build-distribution/)

### Upload Metadata
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this section is redundant since it also appears in the sections for each platform.


### CI Integration

Integrate Build Distribution into your CI pipeline to automatically distribute builds to your teams.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to mention anything else?
There's no difference if a build is uploaded from a local build vs a CI build for the purposes of size analysis. There isn't any github integration either.


// If a new language should be supported, add it here and register it in refractor above
export const SUPPORTED_LANGUAGES = ['bash', 'json', 'typescript'];
export const SUPPORTED_LANGUAGES = ['bash', 'groovy', 'json', 'kotlin', 'typescript'];
Copy link
Contributor

@runningcode runningcode Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, i think this was the fix for the language syntax highlighting inside codeToJsx 😓


<Include name="size-analysis/build-configuration-ios" />

## Distribution Management
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is something missing here? It seems like there's no content for 'Distribution Management' under this header.


## What's Next?

We strongly recommend integrating Build Distribution into your CI pipeline for automated distribution workflows.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be misinterpreting, but is this recommending what we've already done on this page as the 'next step'? Is there a recommended next step that can link to another place in docs?

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big lift, thanks for adding all this! I added a couple of questions for clarification, but overall looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants