Add suggestions

Author: limbonaut

.github/workflows/test_android.yml

@@ -41,7 +41,7 @@ jobs:
         uses: reactivecircus/android-emulator-runner@b530d96654c385303d652368551fb075bc2f0b6b # [email protected]
         timeout-minutes: 30
         with:
-          api-level: 30
+          api-level: 34
           target: "google_apis"
           channel: "stable"
           force-avd-creation: true

project/test/suites/test_breadcrumbs_json.gd

@@ -30,6 +30,7 @@ func test_breadcrumbs_with_minimal_breadcrumb() -> void:
 		.either() \
 			.must_not_contain("data") \
 		.or_else() \
+			# NOTE: Android always adds data field, even if empty.
 			.must_contain("data", {}) \
 		.end() \
 

project/test/suites/test_event.gd

@@ -42,7 +42,7 @@ func test_event_timestamp() -> void:
 	# Test assigning a custom timestamp from microseconds
 	var custom_timestamp := SentryTimestamp.from_microseconds_since_unix_epoch(1612325106123456)
 	event.timestamp = custom_timestamp
-	# millisecond precision on some platforms
+	# NOTE: Millisecond precision on Android
 	assert_int(event.timestamp.microseconds_since_unix_epoch).is_between(1612325106123000, 1612325106123456)
 
 	# Test assigning timestamp from current time

scripts/run-android-tests.sh

@@ -276,9 +276,9 @@ run_tests() {
 
 
 # Discover isolated test suites and add normal suites as first item
-TEST_PATHS=("res://test/suites/")
 blankline
 highlight "Looking for isolated test suites..."
+TEST_PATHS=("res://test/suites/")
 TEST_PATHS+=($(find project/test/isolated -name "test_*.gd" -type f | sort))
 
 # Check if any isolated tests were found