typing

Author: ceorourke

src/sentry/incidents/metric_issue_detector.py

@@ -1,5 +1,5 @@
 from datetime import timedelta
-from typing import Any
+from typing import Any, cast
 
 from rest_framework import serializers
 
@@ -245,7 +245,8 @@ def update_data_source(self, instance: Detector, data_source: SnubaQueryDataSour
                 "query"
             ) or snuba_query.aggregate != data_source.get("aggregate"):
                 try:
-                    update_detector_data(instance, data_source)
+                    validated_data_source = cast(dict[str, Any], data_source)
+                    update_detector_data(instance, validated_data_source)
                 except Exception:
                     # don't update the snuba query if we failed to send data to Seer
                     raise serializers.ValidationError(

src/sentry/seer/anomaly_detection/store_data_workflow_engine.py

@@ -43,7 +43,7 @@
 
 def _fetch_related_models(
     detector: Detector, method: str
-) -> tuple[DataSource, DataCondition, SnubaQuery] | None:
+) -> tuple[DataSource, DataCondition, SnubaQuery]:
     # XXX: it is technically possible (though not used today) that a detector could have multiple data sources
     data_source_detector = DataSourceDetector.objects.filter(detector_id=detector.id).first()
     if not data_source_detector:
@@ -84,6 +84,7 @@ def update_detector_data(
     updated_fields: dict[str, Any],
 ) -> None:
     data_source, data_condition, snuba_query = _fetch_related_models(detector, "update")
+
     # use setattr to avoid saving the models until the Seer call has successfully finished,
     # otherwise they would be in a bad state
     updated_data_condition_data = updated_fields.get("condition_group", {}).get("conditions")
@@ -127,6 +128,7 @@ def send_new_detector_data(detector: Detector) -> None:
     Send historical data for a new Detector to Seer.
     """
     data_source, data_condition, snuba_query = _fetch_related_models(detector, "create")
+
     try:
         handle_send_historical_data_to_seer(
             detector, data_source, data_condition, snuba_query, detector.project, SeerMethod.CREATE

tests/sentry/incidents/endpoints/validators/test_validators.py

@@ -194,7 +194,7 @@ def setUp(self) -> None:
             },
         }
 
-    def create_static_detector(self) -> None:
+    def create_static_detector(self) -> Detector:
         validator = MetricIssueDetectorValidator(
             data=self.valid_data,
             context=self.context,
@@ -224,7 +224,7 @@ def create_static_detector(self) -> None:
 
         return static_detector
 
-    def create_dynamic_detector(self) -> None:
+    def create_dynamic_detector(self) -> Detector:
         validator = MetricIssueDetectorValidator(
             data=self.valid_anomaly_detection_data,
             context=self.context,