Skip to content

Commit 591b4ea

Browse files
authored
chore(aci): bump offset for fake IDs (#104051)
I'm a bit concerned that we have 500 million+ open periods already. Bump the offset for fake IDs to 10 billion so there's a vastly reduced risk of us running into it with real open period IDs.
1 parent c17cd02 commit 591b4ea

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/sentry/incidents/endpoints/serializers/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
OFFSET = 10**9
1+
OFFSET = 10**10
22

33

44
def get_fake_id_from_object_id(obj_id: int) -> int:

tests/sentry/incidents/serializers/test_workflow_engine_detector.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
from django.core.cache import cache
66

77
from sentry.api.serializers import serialize
8+
from sentry.incidents.endpoints.serializers.utils import OFFSET
89
from sentry.incidents.endpoints.serializers.workflow_engine_detector import (
910
WorkflowEngineDetectorSerializer,
1011
)
@@ -22,8 +23,6 @@
2223
TestWorkflowEngineSerializer,
2324
)
2425

25-
OFFSET = 10**9
26-
2726

2827
class TestDetectorSerializer(TestWorkflowEngineSerializer):
2928
def setUp(self) -> None:

0 commit comments

Comments
 (0)