update for resolution conditions

Author: ceorourke

src/sentry/seer/anomaly_detection/store_data_workflow_engine.py

@@ -31,7 +31,7 @@
 from sentry.utils import json, metrics
 from sentry.utils.json import JSONDecodeError
 from sentry.workflow_engine.models import DataCondition, DataSource, DataSourceDetector, Detector
-from sentry.workflow_engine.types import DetectorException
+from sentry.workflow_engine.types import DetectorException, DetectorPriorityLevel
 
 logger = logging.getLogger(__name__)
 
@@ -64,10 +64,15 @@ def _fetch_related_models(
         )
     try:
         data_condition = DataCondition.objects.get(
-            condition_group=detector.workflow_condition_group
+            condition_group=detector.workflow_condition_group,
+            condition_result__in=[
+                DetectorPriorityLevel.HIGH,
+                DetectorPriorityLevel.MEDIUM,
+                DetectorPriorityLevel.LOW,
+            ],
         )
     except (DataCondition.DoesNotExist, DataCondition.MultipleObjectsReturned):
-        # there should only ever be one data condition for a dynamic metric detector, we dont actually expect a MultipleObjectsReturned
+        # there should only ever be one non-resolution data condition for a dynamic metric detector, we dont actually expect a MultipleObjectsReturned
         dcg_id = (
             detector.workflow_condition_group.id
             if detector.workflow_condition_group is not None

tests/sentry/incidents/endpoints/validators/test_validators.py

@@ -625,6 +625,12 @@ def test_update_with_valid_data(self) -> None:
                         "comparison": 100,
                         "conditionResult": DetectorPriorityLevel.HIGH,
                     },
+                    {
+                        "type": Condition.LESS_OR_EQUAL,
+                        "comparison": 100,
+                        "conditionResult": DetectorPriorityLevel.OK,
+                        "conditionGroupId": self.data_condition_group.id,
+                    },
                 ],
             },
             "name": new_name,  # change the name
@@ -842,7 +848,7 @@ def test_anomaly_detection__send_historical_data_update_fails(
         assert condition_group.organization_id == self.project.organization_id
 
         conditions = list(DataCondition.objects.filter(condition_group=condition_group))
-        assert len(conditions) == 1
+        assert len(conditions) == 2
         condition = conditions[0]
         assert condition.type == Condition.GREATER
         assert condition.comparison == 100