ref(✂️): update knip and address new findings (#104151)

knip got better and finds more stuff now 🙌

Author: TkDodo

package.json

@@ -223,7 +223,7 @@
     "jest-environment-jsdom": "30.0.4",
     "jest-fail-on-console": "3.3.1",
     "jest-junit": "16.0.0",
-    "knip": "5.64.0",
+    "knip": "5.71.0",
     "postcss-styled-syntax": "0.7.0",
     "react-refresh": "0.18.0",
     "stylelint": "16.10.0",

pnpm-lock.yaml

@@ -12,7 +12,6 @@ import type {ReprocessEventModalOptions} from 'sentry/components/modals/reproces
 import type {TokenRegenerationConfirmationModalProps} from 'sentry/components/modals/tokenRegenerationConfirmationModal';
 import type {AddToDashboardModalProps} from 'sentry/components/modals/widgetBuilder/addToDashboardModal';
 import type {LinkToDashboardModalProps} from 'sentry/components/modals/widgetBuilder/linkToDashboardModal';
-import type {OverwriteWidgetModalProps} from 'sentry/components/modals/widgetBuilder/overwriteWidgetModal';
 import type {WidgetViewerModalOptions} from 'sentry/components/modals/widgetViewerModal';
 import type {ConsoleModalProps} from 'sentry/components/onboarding/consoleModal';
 import type {Category} from 'sentry/components/platformPicker';
@@ -263,19 +262,6 @@ export async function openInviteMissingMembersModal({
   });
 }
 
-export async function openWidgetBuilderOverwriteModal(
-  options: OverwriteWidgetModalProps
-) {
-  const {default: Modal, modalCss} = await import(
-    'sentry/components/modals/widgetBuilder/overwriteWidgetModal'
-  );
-
-  openModal(deps => <Modal {...deps} {...options} />, {
-    closeEvents: 'escape-key',
-    modalCss,
-  });
-}
-
 export async function openAddToDashboardModal(options: AddToDashboardModalProps) {
   const {default: Modal, modalCss} = await import(
     'sentry/components/modals/widgetBuilder/addToDashboardModal'
@@ -328,7 +314,7 @@ export async function demoSignupModal(options: ModalOptions = {}) {
   openModal(deps => <Modal {...deps} {...options} />, {modalCss});
 }
 
-export type DemoEndModalOptions = {
+type DemoEndModalOptions = {
   tour: string;
 };
 
@@ -389,7 +375,7 @@ export async function openCreateReleaseIntegration(
   openModal(deps => <Modal {...deps} {...options} />);
 }
 
-export type NavigateToExternalLinkModalOptions = {
+type NavigateToExternalLinkModalOptions = {
   linkText: string;
 };
 
@@ -488,7 +474,7 @@ export async function openPrivateGamingSdkAccessModal(
   openModal(deps => <PrivateGamingSdkAccessModal {...deps} {...options} />);
 }
 
-export type InsightInfoModalOptions = {
+type InsightInfoModalOptions = {
   children: React.ReactNode;
   title: string;
 };

static/app/actionCreators/modal.tsx

@@ -112,7 +112,7 @@ const issueTypeConfig: Config = {
  * errors that may otherwise be difficult to debug. For example, common framework
  * errors that have no stack trace.
  */
-export function shouldShowCustomErrorResourceConfig(
+function shouldShowCustomErrorResourceConfig(
   params: GetConfigForIssueTypeParams,
   project: Project
 ): boolean {

static/app/components/modals/widgetBuilder/overwriteWidgetModal.spec.tsx

@@ -6,7 +6,7 @@ import type {Widget} from 'sentry/views/dashboards/types';
 import {DisplayType, WidgetType} from 'sentry/views/dashboards/types';
 import {hasDatasetSelector} from 'sentry/views/dashboards/utils';
 
-export type WidgetTemplate = Widget & {
+type WidgetTemplate = Widget & {
   description: string;
 };