Skip to content

Commit b80dec5

Browse files
committed
create util for migrated alert condition
1 parent 392ff41 commit b80dec5

File tree

3 files changed

+26
-14
lines changed

3 files changed

+26
-14
lines changed

static/app/views/alerts/rules/metric/details/body.tsx

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ import type {MetricRule} from 'sentry/views/alerts/rules/metric/types';
2929
import {
3030
AlertRuleComparisonType,
3131
Dataset,
32-
ExtrapolationMode,
3332
TimePeriod,
3433
} from 'sentry/views/alerts/rules/metric/types';
3534
import {extractEventTypeFilterFromRule} from 'sentry/views/alerts/rules/metric/utils/getEventTypeFilter';
@@ -48,7 +47,7 @@ import MetricChart from './metricChart';
4847
import RelatedIssues from './relatedIssues';
4948
import RelatedTransactions from './relatedTransactions';
5049
import {MetricDetailsSidebar} from './sidebar';
51-
import {getFilter, getPeriodInterval} from './utils';
50+
import {getFilter, getIsMigratedExtrapolationMode, getPeriodInterval} from './utils';
5251

5352
interface MetricDetailsBodyProps {
5453
timePeriod: TimePeriodType;
@@ -144,11 +143,9 @@ export default function MetricDetailsBody({
144143
const deprecateTransactionsAlertsWarning =
145144
ruleType && DEPRECATED_TRANSACTION_ALERTS.includes(ruleType);
146145

147-
const showExtrapolationModeWarning = !!(
148-
rule.dataset === Dataset.EVENTS_ANALYTICS_PLATFORM &&
149-
rule.extrapolationMode &&
150-
(rule.extrapolationMode === ExtrapolationMode.SERVER_WEIGHTED ||
151-
rule.extrapolationMode === ExtrapolationMode.NONE)
146+
const showExtrapolationModeWarning = getIsMigratedExtrapolationMode(
147+
rule.extrapolationMode,
148+
rule.dataset
152149
);
153150

154151
return (

static/app/views/alerts/rules/metric/details/utils.tsx

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,12 @@ import {
88
TIME_WINDOWS,
99
type TimePeriodType,
1010
} from 'sentry/views/alerts/rules/metric/details/constants';
11-
import type {MetricRule} from 'sentry/views/alerts/rules/metric/types';
12-
import {Dataset, TimePeriod} from 'sentry/views/alerts/rules/metric/types';
11+
import {
12+
Dataset,
13+
ExtrapolationMode,
14+
TimePeriod,
15+
type MetricRule,
16+
} from 'sentry/views/alerts/rules/metric/types';
1317
import {extractEventTypeFilterFromRule} from 'sentry/views/alerts/rules/metric/utils/getEventTypeFilter';
1418
import {isCrashFreeAlert} from 'sentry/views/alerts/rules/metric/utils/isCrashFreeAlert';
1519
import type {Incident} from 'sentry/views/alerts/types';
@@ -123,3 +127,15 @@ export function getViableDateRange({
123127
end: viableEndDate,
124128
};
125129
}
130+
131+
export function getIsMigratedExtrapolationMode(
132+
extrapolationMode: ExtrapolationMode | undefined,
133+
dataset: Dataset
134+
) {
135+
return !!(
136+
dataset === Dataset.EVENTS_ANALYTICS_PLATFORM &&
137+
extrapolationMode &&
138+
(extrapolationMode === ExtrapolationMode.SERVER_WEIGHTED ||
139+
extrapolationMode === ExtrapolationMode.NONE)
140+
);
141+
}

static/app/views/alerts/rules/metric/ruleForm.tsx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ import {
5050
} from 'sentry/utils/onDemandMetrics/features';
5151
import withProjects from 'sentry/utils/withProjects';
5252
import {makeAlertsPathname} from 'sentry/views/alerts/pathnames';
53+
import {getIsMigratedExtrapolationMode} from 'sentry/views/alerts/rules/metric/details/utils';
5354
import {IncompatibleAlertQuery} from 'sentry/views/alerts/rules/metric/incompatibleAlertQuery';
5455
import {OnDemandThresholdChecker} from 'sentry/views/alerts/rules/metric/onDemandThresholdChecker';
5556
import RuleNameOwnerForm from 'sentry/views/alerts/rules/metric/ruleNameOwnerForm';
@@ -1377,11 +1378,9 @@ class RuleFormContainer extends DeprecatedAsyncComponent<Props, State> {
13771378
const showErrorMigrationWarning =
13781379
!!ruleId && isMigration && ruleNeedsErrorMigration(rule);
13791380

1380-
const showExtrapolationModeChangeWarning = !!(
1381-
dataset === Dataset.EVENTS_ANALYTICS_PLATFORM &&
1382-
extrapolationMode &&
1383-
(extrapolationMode === ExtrapolationMode.SERVER_WEIGHTED ||
1384-
extrapolationMode === ExtrapolationMode.NONE)
1381+
const showExtrapolationModeChangeWarning = getIsMigratedExtrapolationMode(
1382+
extrapolationMode,
1383+
dataset
13851384
);
13861385

13871386
// Rendering the main form body

0 commit comments

Comments
 (0)