Skip to content

Commit c848b31

Browse files
authored
fix(dashboards): Fix trigger for single value global filter selector (#104107)
For non multi select filters, we don't externally manage staged filter values (which we do for multi selects via `HybridFilter`). So instead of passing in staged values into the trigger for single select filters, we should pass in the actual active filter values parsed from the global filter value.
1 parent eeb2733 commit c848b31

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

static/app/views/dashboards/globalFilter/filterSelector.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -289,10 +289,10 @@ function FilterSelector({
289289
</Flex>
290290
);
291291

292-
const renderFilterSelectorTrigger = () => (
292+
const renderFilterSelectorTrigger = (filterValues: string[]) => (
293293
<FilterSelectorTrigger
294294
globalFilter={globalFilter}
295-
activeFilterValues={stagedFilterValues}
295+
activeFilterValues={filterValues}
296296
operator={stagedOperator}
297297
options={options}
298298
queryResult={queryResult}
@@ -320,7 +320,7 @@ function FilterSelector({
320320
}
321321
menuHeaderTrailingItems={renderMenuHeaderTrailingItems}
322322
triggerProps={{
323-
children: renderFilterSelectorTrigger(),
323+
children: renderFilterSelectorTrigger(activeFilterValues),
324324
}}
325325
/>
326326
);
@@ -376,7 +376,7 @@ function FilterSelector({
376376
}
377377
menuHeaderTrailingItems={renderMenuHeaderTrailingItems}
378378
triggerProps={{
379-
children: renderFilterSelectorTrigger(),
379+
children: renderFilterSelectorTrigger(stagedFilterValues),
380380
}}
381381
/>
382382
);

0 commit comments

Comments
 (0)