Commit dd321dd
authored
chore(releases): fix releases tooltip width (#103955)
problem described in [feedback
here](https://sentry.sentry.io/issues/feedback/?alert_rule_id=16206265&alert_type=issue&feedbackSlug=javascript%3A7051903700¬ification_uuid=bf8ffb13-67dc-4466-b2ed-78cad32f187b&project=11276&referrer=slack&statsPeriod=7d).
TL;DR - releases cards can have the same subset of title displayed, but
the tooltip was getting cut off
## PR vs. current
**PR**
_tooltips show full content (can see the bundle ids are different)_
<img width="329" height="142" alt="image"
src="https://github.com/user-attachments/assets/4ac02a24-c526-42b3-aaec-756e594d0299"
/>
https://github.com/user-attachments/assets/af731c7c-a4cd-4e79-aec2-c87cc09862d4
**current prod (releases indistinguishable)**
<img width="600" height="223" alt="image"
src="https://github.com/user-attachments/assets/ecb063e2-9298-418d-aae7-60d78636cfa7"
/>
https://github.com/user-attachments/assets/f0e196a0-31cc-435e-9301-1e96ce1d8b04
## For a hash release
intent is to not change current behavior
**Tooltip on prod for a "hash release"**
<img width="364" height="202" alt="image"
src="https://github.com/user-attachments/assets/7564cf4d-5fde-4488-8ac8-ac26100e7816"
/>
**Tooltip in PR for a "hash release" (same thing)**
<img width="388" height="176" alt="image"
src="https://github.com/user-attachments/assets/95de6bdb-14df-4fcc-96d8-f7090a8fea4d"
/>
## Notes
**Issues w/ previous implementation:**
- regex for hash version was incorrect given the `version` that's passed
in. The `version` passed in is actually the full release string, that
often will start with something like `frontend@{hash}`. Changed regex to
be if there is a 40 or 64 character hash anywhere, which worked for the
Sentry Javascript project
- the overlayStyle wasn't actually doing anything, otherwise this never
would have been issue. Switched to just use the maxWidth prop that's in
the tooltip1 parent 84aab2a commit dd321dd
1 file changed
+3
-17
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | | - | |
| 71 | + | |
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
| |||
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | 135 | | |
150 | 136 | | |
151 | 137 | | |
152 | 138 | | |
153 | 139 | | |
154 | 140 | | |
155 | | - | |
| 141 | + | |
156 | 142 | | |
157 | 143 | | |
158 | 144 | | |
| |||
0 commit comments