Skip to content

Commit e51184d

Browse files
authored
chore(ACI): Clean up metric issue (#103569)
Remove the no longer used metric issue poc, some text indicating that metric issue is still wip (it is not), and update the config description to be accurate.
1 parent b95d638 commit e51184d

File tree

2 files changed

+1
-17
lines changed

2 files changed

+1
-17
lines changed

src/sentry/incidents/grouptype.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -318,8 +318,6 @@ def construct_title(
318318
)
319319

320320

321-
# Example GroupType and detector handler for metric alerts. We don't create these issues yet, but we'll use something
322-
# like these when we're sending issues as alerts
323321
@dataclass(frozen=True)
324322
class MetricIssue(GroupType):
325323
type_id = 8001
@@ -339,7 +337,7 @@ class MetricIssue(GroupType):
339337
validator=MetricIssueDetectorValidator,
340338
config_schema={
341339
"$schema": "https://json-schema.org/draft/2020-12/schema",
342-
"description": "A representation of a metric alert firing",
340+
"description": "A representation of a metric detector config dict",
343341
"type": "object",
344342
"required": ["detection_type"],
345343
"properties": {

src/sentry/issues/grouptype.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -672,20 +672,6 @@ class FeedbackGroup(GroupType):
672672
enable_escalation_detection = False
673673

674674

675-
@dataclass(frozen=True)
676-
class MetricIssuePOC(GroupType):
677-
# DEPRECATED, use metric_issue (8001) instead
678-
type_id = 8002
679-
slug = "metric_issue_poc"
680-
description = "DEPRECATED Metric Issue POC"
681-
category = GroupCategory.METRIC_ALERT.value
682-
category_v2 = GroupCategory.METRIC.value
683-
default_priority = PriorityLevel.HIGH
684-
enable_auto_resolve = False
685-
enable_escalation_detection = False
686-
enable_status_change_workflow_notifications = False
687-
688-
689675
@dataclass(frozen=True)
690676
class WebVitalsGroup(GroupType): # TODO: Rename to WebVitalsGroupType
691677
type_id = 10001

0 commit comments

Comments
 (0)