fix

Author: kcons

src/sentry/workflow_engine/processors/data_condition_group.py

@@ -41,18 +41,20 @@ class TriggerResult:
 
     @staticmethod
     def any(items: Iterable["TriggerResult"]) -> "TriggerResult":
-        for _ in (item for item in items if item.triggered and item.error is None):
+        items_list = list(items)
+        for _ in (item for item in items_list if item.triggered and item.error is None):
             return TriggerResult(triggered=True, error=None)
         # If we didn't have any untained Trues, the result is tainted.
-        some_error = next((item.error for item in items if item.error is not None), None)
-        return TriggerResult(triggered=any(item.triggered for item in items), error=some_error)
+        some_error = next((item.error for item in items_list if item.error is not None), None)
+        return TriggerResult(triggered=any(item.triggered for item in items_list), error=some_error)
 
     @staticmethod
     def all(items: Iterable["TriggerResult"]) -> "TriggerResult":
-        some_error = next((item.error for item in items if item.error is not None), None)
+        items_list = list(items)
+        some_error = next((item.error for item in items_list if item.error is not None), None)
         # if anything was tainted, the result is tainted.
         return TriggerResult(
-            triggered=all(item.triggered for item in items),
+            triggered=all(item.triggered for item in items_list),
             error=some_error,
         )
 

tests/sentry/workflow_engine/processors/test_data_condition_group.py

@@ -546,3 +546,25 @@ def test_all_all_false_untainted_returns_untainted_false(self):
         result = TriggerResult.all(items)
         assert result.triggered is False
         assert result.error is None
+
+    def test_any_with_generator_preserves_error(self):
+        error = ConditionError(msg="test error")
+        items = [
+            TriggerResult(triggered=False, error=None),
+            TriggerResult(triggered=False, error=error),
+            TriggerResult(triggered=False, error=None),
+        ]
+        result = TriggerResult.any(item for item in items)
+        assert result.triggered is False
+        assert result.error == error
+
+    def test_all_with_generator_preserves_error(self):
+        error = ConditionError(msg="test error")
+        items = [
+            TriggerResult(triggered=True, error=None),
+            TriggerResult(triggered=True, error=error),
+            TriggerResult(triggered=True, error=None),
+        ]
+        result = TriggerResult.all(item for item in items)
+        assert result.triggered is True
+        assert result.error == error