Skip to content

Commit 1eee22f

Browse files
authored
fix(gocd): fix gocd filters for rs/py deploys (#7545)
Right now, our deploy-snuba-py filters match every change in snuba and our deploy-snuba-rs filters match none. Doing a little research, I found that there's a different way to specify file paths: gocd/gocd#9859 (comment) I tested locally with a Docker GoCD and a forked copy of snuba, that `rust_snuba/**/*` seems to correctly match changes under the `rust_snuba` tree (deny or allow)
1 parent 2724c04 commit 1eee22f

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

gocd/templates/pipelines/snuba-py.libsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ function(region) {
161161
shallow_clone: false,
162162
branch: 'master',
163163
destination: 'snuba',
164-
ignore: ['rust_snuba/**'],
164+
ignore: ['rust_snuba/**/*'],
165165
},
166166
},
167167
stages: [

gocd/templates/pipelines/snuba-rs.libsonnet

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -119,11 +119,11 @@ function(region) {
119119
branch: 'master',
120120
destination: 'snuba',
121121
includes: [
122-
'rust_snuba/**',
123-
'snuba/datasets/configuration/**',
124-
'snuba/settings/**',
122+
'rust_snuba/**/*',
123+
'snuba/datasets/configuration/**/*',
124+
'snuba/settings/**/*',
125125
'Dockerfile',
126-
'snuba/cli/**',
126+
'snuba/cli/**/*',
127127
],
128128
},
129129
},

gocd/templates/snuba-py.jsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ local py_pipedream_config = {
99
shallow_clone: true,
1010
branch: 'master',
1111
destination: 'snuba',
12-
ignore: ['rust_snuba/**'],
12+
ignore: ['rust_snuba/**/*'],
1313
},
1414
},
1515
rollback: {

gocd/templates/snuba-rs.jsonnet

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@ local rs_pipedream_config = {
1010
branch: 'master',
1111
destination: 'snuba',
1212
includes: [
13-
'rust_snuba/**',
14-
'snuba/datasets/configuration/**',
15-
'snuba/settings/**',
13+
'rust_snuba/**/*',
14+
'snuba/datasets/configuration/**/*',
15+
'snuba/settings/**/*',
1616
'Dockerfile',
17-
'snuba/cli/**',
17+
'snuba/cli/**/*',
1818
],
1919
},
2020
},

0 commit comments

Comments
 (0)