Commit 965ccfa
authored
chore: stop capturing redis oom set failure in sentry (#7528)
I was just looking into one of the errors that triggered our [Critical:
Snuba errors over 30
minutes.](https://sentry.sentry.io/issues/alerts/rules/details/46321/?alert=230878&referrer=metric_alert_slack&detection_type=static¬ification_uuid=653cde63-5ca2-4d50-8fa1-933cab7377bd)
It was ResponseError: OOM command not allowed under OOM prevention. This
comes from our redis cache when it reaches max memory. The cache has an
lru eviction policy when it fills up so usually this doesnt happen, but
occasionally it still can.
We have a datadog metric,
[snuba.read_through_cache.redis_cache_set_error](https://app.datadoghq.com/metric/explorer?graph_layout=stacked&start=1762286323568&end=1762891123568&paused=false#N4Ig7glgJg5gpgFxALlAGwIYE8D2BXJVEADxQEYAaELcqyKBAC1pEbghkcLIF8qo4AMwgA7CAgg4RKUAiwAHOChASAtnADOcAE4RNIKtrgBHPJoQaUAbVBGN8qVoD6gnNtUZCKiOq279VKY6epbINiAiGOrKQdpYZAYgUJ4YThr42gDGSsgg6gi6mZaBZnHKGniqyBoieABGGAB0RhhQTkza+JxOmRiZbM1wUBAaPX1saYhOOp3awFoiBVhORjCSIsh4GjyNGKOZ+IsAFACUIDwAulSu7niYoeE3qncYMaXx51cgGnJoOaDyDB-BAIHJJHAwHr3DQQTKJNCiODtBRg9IIqDwxFOehMZQiNweNDnfgjeSYZZyRTKBEiJSXHh8b5k8QAYSkwhgKFqaDQPCAA)
that basically exactly tracks this errors occurrence. In order to reduce
feed-sns noise I will remove this error from sentry and instead use the
datadog metric to monitor the percentage of redis cache writes that
fail, and have a monitor on it that will send in feed-sns if it ever
gets too high.
[Here is the new monitor I
created](https://app.datadoghq.com/monitors/236008510) and here [a new
widget I added in the api
dashboard](https://app.datadoghq.com/dashboard/spg-jqb-tgz/snuba-api?fromUser=true&refresh_mode=paused&tpl_var_sentry_region%5B0%5D=us&from_ts=1762366350809&to_ts=1762370761457&live=false&tile_focus=1728346643271425)
This PR stops capturing the sentry metric1 parent ec9d8fb commit 965ccfa
1 file changed
+10
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| |||
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
25 | 31 | | |
26 | 32 | | |
27 | 33 | | |
| |||
71 | 77 | | |
72 | 78 | | |
73 | 79 | | |
74 | | - | |
| 80 | + | |
| 81 | + | |
75 | 82 | | |
76 | 83 | | |
77 | 84 | | |
| |||
91 | 98 | | |
92 | 99 | | |
93 | 100 | | |
94 | | - | |
| 101 | + | |
| 102 | + | |
95 | 103 | | |
96 | 104 | | |
97 | 105 | | |
| |||
0 commit comments