-
Notifications
You must be signed in to change notification settings - Fork 520
fix: enable albyhub app proxy auth by default #4028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
albyhub/docker-compose.yml
Outdated
| APP_HOST: albyhub_server_1 | ||
| APP_PORT: 8080 | ||
| PROXY_AUTH_ADD: "false" | ||
| PROXY_AUTH_ADD: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't true the default here so you can omit the whole line?
From the docs:
The Umbrel App Proxy automatically protects an app by requiring the user to enter their Umbrel password
| PROXY_AUTH_ADD: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the default. Also I just test it locally and indeed the whole line is unnecessary, it's removed now.
32f5f2b to
c4aa414
Compare
|
@nmfretz I thank you in advance for reviewing and merging this 🙏 |
|
Awesome @NodeDiver, really glad to see Alby Hub utilizing the auth proxy.
And in addition to needing to enter the umbrel password if not signed in, if a user has 2FA set up on their Umbrel then Alby also sits behind that! In order for existing users to get an app update notification the What's better for you guys:
version: 1.20.0-author version: 1.20.0-hotfix.1And then add release notes like: releaseNotes: >-
This release adds additional security to your Alby Hub app on umbrelOS by ...
No other changes to Alby Hub are included in this release.
Full release notes are found at https://github.com/getAlby/hub/releases |
|
Hey, @nmfretz , You can use Thanks!!! |
🎉 Linting finished with no errors or warnings 🎉Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store. |
|
Excellent, thanks again @NodeDiver! Here's what I've done for the release notes:
Reviewed and tested connections. If a user is not logged in to their Umbrel they would be met with this screen if trying to access the Alby Hub app directly:
|


This forces anyone visiting the app to authenticate with their Umbrel account even if the Alby Hub unlock password is known. Adds a safety layer when users mismanage credentials, requiring both the Umbrel password and the Alby Hub unlock password to gain access.