Skip to content

Commit 968ba10

Browse files
dschoGit for Windows Build Agent
authored andcommitted
ci(macos): skip the git p4 tests (#5954)
Historically, the macOS jobs have always been among the longest-running ones, and recently the `git p4` tests became another liability: They started to fail much more often (maybe as of the switch away from the `macos-13` pool?), requiring re-runs of the jobs that already were responsible for long CI build times. Of the 35 test scripts that exercise `git p4`, 32 are actually run on macOS (3 are skipped for reasons like case-sensitivee filesystem), and they take an accumulated runtime of over half an hour. Furthermore, the `git p4` command is not really affected by Git for Windows' patches, at least not as far as macOS is concerned, therefore it is not only causing developer friction to have these long-running, frequently failing tests, it is also quite wasteful: There has not been a single instance so far where any `git p4` test failure in Git for Windows had demonstrated an actionable bug. So let's just disable those tests in the CI runs, at least on macOS.
2 parents 5c21ea3 + 193841b commit 968ba10

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

ci/install-dependencies.sh

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -102,11 +102,12 @@ macos-*)
102102
# brew install gnu-time
103103
brew link --force gettext
104104

105-
mkdir -p "$CUSTOM_PATH"
106-
wget -q "$P4WHENCE/bin.macosx1015x86_64/helix-core-server.tgz" &&
107-
tar -xf helix-core-server.tgz -C "$CUSTOM_PATH" p4 p4d &&
108-
sudo xattr -d com.apple.quarantine "$CUSTOM_PATH/p4" "$CUSTOM_PATH/p4d" 2>/dev/null || true
109-
rm helix-core-server.tgz
105+
# Uncomment this block if you want to run `git p4` tests:
106+
# mkdir -p "$CUSTOM_PATH"
107+
# wget -q "$P4WHENCE/bin.macosx1015x86_64/helix-core-server.tgz" &&
108+
# tar -xf helix-core-server.tgz -C "$CUSTOM_PATH" p4 p4d &&
109+
# sudo xattr -d com.apple.quarantine "$CUSTOM_PATH/p4" "$CUSTOM_PATH/p4d" 2>/dev/null || true
110+
# rm helix-core-server.tgz
110111

111112
case "$jobname" in
112113
osx-meson)

0 commit comments

Comments
 (0)