Secret Scanning pattern docs refactor (#58635)

Co-authored-by: Copilot <[email protected]>

Author: NicelyDunn7

src/secret-scanning/data/pattern-docs/fpt/public-docs.yml

@@ -1,20 +1,8 @@
-import { schema } from '@/frame/lib/frontmatter'
-
-// Secret scanning entries have `versions` blocks that match `versions` frontmatter,
-// so we can import that part of the FM schema.
-// Access the versions property which is defined dynamically in frontmatter.ts
-const versionsProps = Object.assign({}, (schema.properties as Record<string, any>).versions)
-
 // The secret-scanning.json contains an array of objects that look like this:
 // {
 //   "provider": "Azure",
 //   "supportedSecret": "Azure SQL Connection String",
 //   "secretType": "azure_sql_connection_string",
-//   "versions": {
-//     "fpt": "*",
-//     "ghec": "*",
-//     "ghes": "*"
-//   },
 //   "isPublic": true,
 //   "isPrivateWithGhas": true,
 //   "hasPushProtection": false,
@@ -27,7 +15,6 @@ export interface SecretScanningEntry {
   provider: string
   supportedSecret: string
   secretType: string
-  versions: Record<string, string>
   isPublic: boolean | string
   isPrivateWithGhas: boolean | string
   hasPushProtection: boolean | string
@@ -45,7 +32,6 @@ export default {
       'provider',
       'supportedSecret',
       'secretType',
-      'versions',
       'isPublic',
       'isPrivateWithGhas',
       'hasPushProtection',
@@ -65,7 +51,6 @@ export default {
         type: 'string',
         pattern: '[A-Za-z0-9_-]',
       },
-      versions: versionsProps,
       isPublic: {
         description: 'whether the secret is publicly available',
         type: ['boolean', 'string'],

src/secret-scanning/data/pattern-docs/ghec/public-docs.yml

@@ -3,7 +3,6 @@ import fs from 'fs'
 import yaml from 'js-yaml'
 import type { NextFunction, Response } from 'express'
 
-import getApplicableVersions from '@/versions/lib/get-applicable-versions'
 import { liquid } from '@/content-render/index'
 import { ExtendedRequest, SecretScanningData } from '@/types'
 import { allVersions } from '@/versions/lib/all-versions'
@@ -38,11 +37,9 @@ export default async function secretScanning(
       : 'fpt'
   const filepath = `${secretScanningDir}/${versionPath}/public-docs.yml`
 
-  const secretScanningData = yaml.load(fs.readFileSync(filepath, 'utf-8')) as SecretScanningData[]
-
-  req.context.secretScanningData = secretScanningData.filter((entry) =>
-    currentVersion ? getApplicableVersions(entry.versions).includes(currentVersion) : false,
-  )
+  req.context.secretScanningData = yaml.load(
+    fs.readFileSync(filepath, 'utf-8'),
+  ) as SecretScanningData[]
 
   // Some entries might use Liquid syntax, so we need
   // to execute that Liquid to get the actual value.