fix(launchpad): transfer launchpad deposit reward (#995)

* fix(launchpad): transfer launchpad deposit reward

* test: check collect reward balance changes

Author: jinoosss

contract/r/gnoswap/launchpad/v1/launchpad_reward.gno

@@ -6,6 +6,7 @@ import (
 	"time"
 
 	"gno.land/r/gnoswap/access"
+	"gno.land/r/gnoswap/common"
 	"gno.land/r/gnoswap/halt"
 )
 
@@ -29,11 +30,17 @@ func (lp *launchpadV1) CollectRewardByDepositId(depositID string) int64 {
 	deposit := lp.mustGetDeposit(depositID)
 	currentHeight := runtime.ChainHeight()
 	currentTime := time.Now().Unix()
-	rewardAmount, err := lp.collectDepositReward(deposit, currentHeight, currentTime)
+
+	rewardTokenPath, rewardAmount, err := lp.collectDepositReward(deposit, currentHeight, currentTime)
 	if err != nil {
 		panic(err)
 	}
 
+	// Transfer reward token to depositor
+	if rewardAmount > 0 {
+		common.SafeGRC20Transfer(cross, rewardTokenPath, deposit.Depositor(), rewardAmount)
+	}
+
 	chain.Emit(
 		"CollectRewardByDepositId",
 		"prevAddr", previousRealm.Address().String(),
@@ -46,33 +53,39 @@ func (lp *launchpadV1) CollectRewardByDepositId(depositID string) int64 {
 }
 
 // collectDepositReward calculates and collects the reward for a deposit.
-func (lp *launchpadV1) collectDepositReward(deposit *Deposit, currentHeight, currentTime int64) (int64, error) {
+func (lp *launchpadV1) collectDepositReward(deposit *Deposit, currentHeight, currentTime int64) (string, int64, error) {
 	if currentTime <= 0 {
-		return 0, makeErrorWithDetails(errInvalidTime, "currentTime must be positive")
+		return "", 0, makeErrorWithDetails(errInvalidTime, "currentTime must be positive")
+	}
+
+	// Get project and tier data
+	project, err := lp.getProject(deposit.ProjectID())
+	if err != nil {
+		return "", 0, err
 	}
 
-	// Get project tier and reward manager
-	projectTier, err := lp.getProjectTier(deposit.ProjectID(), deposit.Tier())
+	projectTier, err := project.getTier(deposit.Tier())
 	if err != nil {
-		return 0, err
+		return "", 0, err
 	}
 
+	// Get reward manager
 	rewardManager, err := lp.getProjectTierRewardManager(projectTier.ID())
 	if err != nil {
-		return 0, err
+		return "", 0, err
 	}
 
 	// Update reward state before collection
 	err = rewardManager.updateRewardPerDepositX128(projectTier.CurrentDepositAmount(), currentHeight, currentTime)
 	if err != nil {
-		return 0, err
+		return "", 0, err
 	}
 
 	// Collect reward
 	rewardAmount, err := rewardManager.collectReward(deposit.ID(), currentTime)
 	if err != nil {
-		return 0, err
+		return "", 0, err
 	}
 
-	return rewardAmount, nil
+	return project.TokenPath(), rewardAmount, nil
 }

contract/r/gnoswap/launchpad/v1/launchpad_reward_test.gno

@@ -4,9 +4,9 @@ import (
 	"chain/runtime"
 	"testing"
 
+	u256 "gno.land/p/gnoswap/uint256"
 	"gno.land/p/nt/avl"
 	"gno.land/p/nt/uassert"
-	u256 "gno.land/p/gnoswap/uint256"
 )
 
 func TestLaunchpadReward_CollectDepositReward(t *testing.T) {
@@ -66,8 +66,9 @@ func TestLaunchpadReward_CollectDepositReward(t *testing.T) {
 				// Create project with tier but without reward manager
 				projects := getTestProjects()
 				project := &Project{
-					id:    "project_1",
-					tiers: make(map[int64]*ProjectTier),
+					id:        "project_1",
+					tokenPath: GNS_PATH,
+					tiers:     make(map[int64]*ProjectTier),
 				}
 				projectTier := &ProjectTier{
 					id:                 "project_1:30",
@@ -100,8 +101,9 @@ func TestLaunchpadReward_CollectDepositReward(t *testing.T) {
 				// Create project with tier
 				projects := getTestProjects()
 				project := &Project{
-					id:    "project_1",
-					tiers: make(map[int64]*ProjectTier),
+					id:        "project_1",
+					tokenPath: GNS_PATH,
+					tiers:     make(map[int64]*ProjectTier),
 				}
 				projectTier := &ProjectTier{
 					id:                  "project_1:30",
@@ -164,8 +166,9 @@ func TestLaunchpadReward_CollectDepositReward(t *testing.T) {
 				// Create project with tier
 				projects := getTestProjects()
 				project := &Project{
-					id:    "project_1",
-					tiers: make(map[int64]*ProjectTier),
+					id:        "project_1",
+					tokenPath: GNS_PATH,
+					tiers:     make(map[int64]*ProjectTier),
 				}
 				projectTier := &ProjectTier{
 					id:                  "project_1:30",
@@ -232,8 +235,9 @@ func TestLaunchpadReward_CollectDepositReward(t *testing.T) {
 				// Create project with tier
 				projects := getTestProjects()
 				project := &Project{
-					id:    "project_1",
-					tiers: make(map[int64]*ProjectTier),
+					id:        "project_1",
+					tokenPath: GNS_PATH,
+					tiers:     make(map[int64]*ProjectTier),
 				}
 				projectTier := &ProjectTier{
 					id:                  "project_1:30",
@@ -284,14 +288,15 @@ func TestLaunchpadReward_CollectDepositReward(t *testing.T) {
 				deposit = tt.deposit
 			}
 
-			amount, err := lp.collectDepositReward(deposit, runtime.ChainHeight(), tt.currentTime)
+			rewardTokenPath, amount, err := lp.collectDepositReward(deposit, runtime.ChainHeight(), tt.currentTime)
 
 			if tt.expectedError != "" {
 				uassert.Error(t, err)
 				uassert.Equal(t, tt.expectedError, err.Error())
 			} else {
 				uassert.NoError(t, err)
 				uassert.Equal(t, tt.expectedAmount, amount)
+				uassert.Equal(t, GNS_PATH, rewardTokenPath)
 			}
 		})
 	}
@@ -404,15 +409,15 @@ func TestLaunchpadReward_CollectDepositRewardTimeBoundaries(t *testing.T) {
 			setTestProjectTierRewardManagers(rewardManagers)
 
 			// Collect reward
-			amount, err := lp.collectDepositReward(deposit, 150, tt.currentTime)
+			rewardTokenPath, amount, err := lp.collectDepositReward(deposit, 150, tt.currentTime)
 			if tt.expectedError != "" {
 				uassert.Error(t, err)
 				uassert.Equal(t, tt.expectedError, err.Error())
 				return
 			}
 
 			uassert.NoError(t, err)
-
+			uassert.Equal(t, "gno.land/r/onbloc/obl", rewardTokenPath)
 			// Verify reward
 			if amount < (tt.expectedReward-5) || amount > (tt.expectedReward+5) {
 				t.Errorf("%s: expected ~%d, got %d", tt.description, tt.expectedReward, amount)