Skip to content

Commit 84146e8

Browse files
committed
fix
1 parent b95fd7e commit 84146e8

File tree

17 files changed

+55
-87
lines changed

17 files changed

+55
-87
lines changed

routers/web/repo/view_file.go

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,6 @@ func handleFileViewRenderMarkup(ctx *context.Context, filename string, sniffedTy
9292
ctx.ServerError("Render", err)
9393
return true
9494
}
95-
// to prevent iframe from loading third-party url
96-
ctx.Resp.Header().Add("Content-Security-Policy", "frame-src 'self'")
9795
return true
9896
}
9997

@@ -241,14 +239,17 @@ func prepareFileView(ctx *context.Context, entry *git.TreeEntry) {
241239
// * IsRenderableXxx: some files are rendered by backend "markup" engine, some are rendered by frontend (pdf, 3d)
242240
// * DefaultViewMode: when there is no "display" query parameter, which view mode should be used by default, source or rendered
243241

244-
utf8Reader := charset.ToUTF8WithFallbackReader(io.MultiReader(bytes.NewReader(buf), dataRc), charset.ConvertOpts{})
242+
contentReader := io.MultiReader(bytes.NewReader(buf), dataRc)
243+
if fInfo.st.IsRepresentableAsText() {
244+
contentReader = charset.ToUTF8WithFallbackReader(contentReader, charset.ConvertOpts{})
245+
}
245246
switch {
246247
case fInfo.blobOrLfsSize >= setting.UI.MaxDisplayFileSize:
247248
ctx.Data["IsFileTooLarge"] = true
248-
case handleFileViewRenderMarkup(ctx, entry.Name(), fInfo.st, buf, utf8Reader):
249+
case handleFileViewRenderMarkup(ctx, entry.Name(), fInfo.st, buf, contentReader):
249250
// it also sets ctx.Data["FileContent"] and more
250251
ctx.Data["IsMarkup"] = true
251-
case handleFileViewRenderSource(ctx, entry.Name(), attrs, fInfo, utf8Reader):
252+
case handleFileViewRenderSource(ctx, entry.Name(), attrs, fInfo, contentReader):
252253
// it also sets ctx.Data["FileContent"] and more
253254
ctx.Data["IsDisplayingSource"] = true
254255
case handleFileViewRenderImage(ctx, fInfo, buf):

tests/gitea-repositories-meta/user30/renderer.git/HEAD

Lines changed: 0 additions & 1 deletion
This file was deleted.

tests/gitea-repositories-meta/user30/renderer.git/config

Lines changed: 0 additions & 6 deletions
This file was deleted.

tests/gitea-repositories-meta/user30/renderer.git/description

Lines changed: 0 additions & 1 deletion
This file was deleted.

tests/gitea-repositories-meta/user30/renderer.git/hooks/post-receive

Lines changed: 0 additions & 15 deletions
This file was deleted.

tests/gitea-repositories-meta/user30/renderer.git/hooks/post-receive.d/gitea

Lines changed: 0 additions & 2 deletions
This file was deleted.

tests/gitea-repositories-meta/user30/renderer.git/hooks/pre-receive

Lines changed: 0 additions & 15 deletions
This file was deleted.

tests/gitea-repositories-meta/user30/renderer.git/hooks/pre-receive.d/gitea

Lines changed: 0 additions & 2 deletions
This file was deleted.

tests/gitea-repositories-meta/user30/renderer.git/hooks/update

Lines changed: 0 additions & 14 deletions
This file was deleted.

tests/gitea-repositories-meta/user30/renderer.git/hooks/update.d/gitea

Lines changed: 0 additions & 2 deletions
This file was deleted.

0 commit comments

Comments
 (0)