Make a new KeyManagementService in a new PlugIns library #1545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rary and obsolete the implementation that is in the main AppEncryption library
* main: Bump the minor-and-patch group across 1 directory with 19 updates Bump the minor-and-patch group across 1 directory with 24 updates Bump the minor-and-patch group across 1 directory with 10 updates Bump Microsoft.Extensions.Logging from 9.0.8 to 9.0.10 Bump Microsoft.Extensions.Configuration from 9.0.8 to 9.0.10 Bump the minor-and-patch group with 7 updates update go.work - bump go version to 1.24.0 Bump the minor-and-patch group across 2 directories with 8 updates Bump the minor-and-patch group across 2 directories with 5 updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The future of the Asherah libaries includes an initiative to move specific implementations of the interfaces in AppEncryption into separate "PlugIn" libraries. This will allow us to provide more flexibility and better separations of various Asherah components.
For example:
Aws PlugIns will contain implementations that are using AWS SDK, While implementations using ADO may have their own PlugIns library.
We could have future plugin libraries that handle optimized implementations for specific framework versions (in case supporting netstandard2.0 and newer dotnet versions requires this).
This change introduces the following new items:
The new implementation in the PlugIns library allows for better integration with standard dotnet startup patterns like using configuration and IServicesCollection.
To help us get this pull request reviewed and merged quickly, please be sure to include the following items:
PR Type
What kind of change does this PR introduce?
Backward Compatibility
Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?
Issue Linking